Differential D45392

sched_4bsd: Rework ESTCPULIM() computation
ClosedPublic
Actions

Authored by olce on May 27 2024, 10:28 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Sep 4, 2:50 AM

	Unknown Object (File)
	Wed, Sep 2, 12:54 AM

	Unknown Object (File)
	Wed, Sep 2, 12:54 AM

	Unknown Object (File)
	Tue, Sep 1, 7:40 PM

	Unknown Object (File)
	Tue, Sep 1, 7:37 PM

	Unknown Object (File)
	Tue, Sep 1, 7:17 PM

	Unknown Object (File)
	Tue, Sep 1, 3:12 PM

	Unknown Object (File)
	Sun, Aug 30, 4:03 PM

Subscribers

Details

Reviewers

jhb
markj
mav
jeff

Commits

rG00c1b4fac2ab: sched_4bsd: Remove RQ_PPQ from ESTCPULIM()'s formula
rGcc604213b597: sched_4bsd: ESTCPULIM(): Allow any value in the timeshare range
rG32766dde5bc3: sched_4bsd: Move ESTCPULIM() after its macro dependencies
rG51a4ae05abe6: sched_4bsd: Remove RQ_PPQ from ESTCPULIM()'s formula
rGeebc148f25c3: sched_4bsd: ESTCPULIM(): Allow any value in the timeshare range
rGa454ff6b0440: sched_4bsd: Move ESTCPULIM() after its macro dependencies

Summary

Please see overview of project at D45393.

Move definition after dependent macros.
Remove RQ_PPQ from the formula. Substracting RQ_PPQ to the maximum number of allowed priority values (the factor to INVERSE_ESTCPU_WEIGHT) has the effect of pessimizing the number of processes assigned to the last priority bucket.
Allow any value in the (now enlarged) timeshare range. The previous formula wastes queues and degrades usage estimation precision, since any increase of ticks that makes adding more than 40 priorities is clamped to the last of these levels.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 59351
Build 56238: arc lint + arc unit

Event Timeline

olce created this revision.May 27 2024, 10:28 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 27 2024, 10:28 PM

olce requested review of this revision.May 27 2024, 10:28 PM

Harbormaster completed remote builds in B57945: Diff 139161.May 27 2024, 10:28 PM

olce added a parent revision: D45391: sched: Internal priority ranges: Reduce kernel, increase timeshare.May 27 2024, 10:29 PM

olce mentioned this in D45393: runq/sched: Switch to 256 distinct queues and extend the timeshare range.May 27 2024, 10:36 PM

olce edited the summary of this revision. (Show Details)May 27 2024, 10:39 PM

Rebase.

Harbormaster completed remote builds in B59351: Diff 143036.Sep 6 2024, 1:53 PM

olce added a parent revision: D46567: sched_ule: Sanitize CPU's use and priority computations, and ticks storage.Sep 6 2024, 1:53 PM

olce removed a parent revision: D45391: sched: Internal priority ranges: Reduce kernel, increase timeshare.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 18 2025, 2:14 AM

Closed by commit rGa454ff6b0440: sched_4bsd: Move ESTCPULIM() after its macro dependencies (authored by olce). · Explain Why

This revision was automatically updated to reflect the committed changes.

olce added a commit: rGa454ff6b0440: sched_4bsd: Move ESTCPULIM() after its macro dependencies.

olce added a commit: rGeebc148f25c3: sched_4bsd: ESTCPULIM(): Allow any value in the timeshare range.

olce added a commit: rG51a4ae05abe6: sched_4bsd: Remove RQ_PPQ from ESTCPULIM()'s formula.Jun 18 2025, 2:19 AM

olce added a commit: rG32766dde5bc3: sched_4bsd: Move ESTCPULIM() after its macro dependencies.Jul 28 2025, 1:32 PM

olce added a commit: rGcc604213b597: sched_4bsd: ESTCPULIM(): Allow any value in the timeshare range.

olce added a commit: rG00c1b4fac2ab: sched_4bsd: Remove RQ_PPQ from ESTCPULIM()'s formula.Jul 28 2025, 1:37 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

8 lines

Diff 143036

sys/kern/sched_4bsd.c

Loading...