loader: Add WITH/WITHOUT_LOADER_PXEBOOT build option
ClosedPublic
Actions

Authored by imp on Aug 2 2024, 5:55 PM.

Details

Reviewers

markj
manu

Commits

rGe179ee000ef2: loader: Add WITH/WITHOUT_LOADER_PXEBOOT build option
rG20d35d581785: loader: Add WITH/WITHOUT_LOADER_PXEBOOT build option

Summary

Make it possible to disable pxeboot. This loader will fail to build when
it's too large. When /boot/loader needs to be larger like that, this
options will disable a component whose build will fail. It is an explicit
option rather than implicit when things are too large to force the user to
make the explicit tradeoffs rather than wonder why they have a stale pxeldr
or other odd failure mode.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 58927
Build 55814: arc lint + arc unit

Event Timeline

imp created this revision.Aug 2 2024, 5:55 PM

Herald added a reviewer: manu. · View Herald TranscriptAug 2 2024, 5:55 PM

Herald added subscribers: dab, emaste, bdrewery. · View Herald Transcript

imp requested review of this revision.Aug 2 2024, 5:55 PM

Harbormaster completed remote builds in B58922: Diff 141742.Aug 2 2024, 5:55 PM

imp added a child revision: D46213: pxeboot: Allow a different default loader for pxeboot.Aug 2 2024, 5:55 PM

Typo in the commit log message, PDELDR -> PXELDR.

tools/build/options/WITH_LOADER_PXELDR
1 ↗	(On Diff #141742)	What's the difference between pxeldr and pxeboot(8)?
8 ↗	(On Diff #141742)
21 ↗	(On Diff #141742)	Should this be `LOADERSIZE`?

markj added inline comments.Aug 2 2024, 6:39 PM

tools/build/options/WITH_LOADER_PXELDR
21 ↗	(On Diff #141742)	Ah, PXELDRSIZE.

imp retitled this revision from loader: Add WITH/WITHOUT_LOADER_PDELDR build option to loader: Add WITH/WITHOUT_LOADER_PXEBOOT build option.Aug 2 2024, 11:33 PM

imp edited the summary of this revision. (Show Details)

update per review, mostly ldr->boot

Harbormaster completed remote builds in B58927: Diff 141757.Aug 2 2024, 11:37 PM

imp added inline comments.Aug 2 2024, 11:38 PM

tools/build/options/WITH_LOADER_PXELDR
1 ↗	(On Diff #141742)	pkeldr is the loader that lives inside of pxeboot. But most people just know about pxeboot, so I'm renaming the new args to match.