Page MenuHomeFreeBSD
Differential D46212

loader: Add WITH/WITHOUT_LOADER_PXEBOOT build option
ClosedPublic
Actions

Authored by imp on Aug 2 2024, 5:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 21, 1:24 PM
Unknown Object (File)
Mon, Apr 20, 5:15 AM
Unknown Object (File)
Fri, Apr 17, 11:04 AM
Unknown Object (File)
Fri, Apr 17, 10:31 AM
Unknown Object (File)
Fri, Apr 17, 5:56 AM
Unknown Object (File)
Wed, Apr 15, 7:31 AM
Unknown Object (File)
Mon, Apr 13, 7:57 PM
Unknown Object (File)
Mon, Apr 13, 9:40 AM
View All Files
Subscribers
bdrewery
dab
emaste

Details

Reviewers
markj
manu
Commits
rGe179ee000ef2: loader: Add WITH/WITHOUT_LOADER_PXEBOOT build option
rG20d35d581785: loader: Add WITH/WITHOUT_LOADER_PXEBOOT build option
Summary

Make it possible to disable pxeboot. This loader will fail to build when
it's too large. When /boot/loader needs to be larger like that, this
options will disable a component whose build will fail. It is an explicit
option rather than implicit when things are too large to force the user to
make the explicit tradeoffs rather than wonder why they have a stale pxeldr
or other odd failure mode.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp created this revision.Aug 2 2024, 5:55 PM
Herald added a reviewer: manu. · View Herald TranscriptAug 2 2024, 5:55 PM
Herald added subscribers: dab, emaste, bdrewery. · View Herald Transcript
imp requested review of this revision.Aug 2 2024, 5:55 PM
Harbormaster completed remote builds in B58922: Diff 141742.Aug 2 2024, 5:55 PM
imp added a child revision: D46213: pxeboot: Allow a different default loader for pxeboot.Aug 2 2024, 5:55 PM
markj added a comment.Aug 2 2024, 6:37 PM

Typo in the commit log message, PDELDR -> PXELDR.

tools/build/options/WITH_LOADER_PXELDR
1 ↗(On Diff #141742)

What's the difference between pxeldr and pxeboot(8)?

8 ↗(On Diff #141742)
21 ↗(On Diff #141742)

Should this be LOADERSIZE?

markj added inline comments.Aug 2 2024, 6:39 PM
tools/build/options/WITH_LOADER_PXELDR
21 ↗(On Diff #141742)

Ah, PXELDRSIZE.

imp retitled this revision from loader: Add WITH/WITHOUT_LOADER_PDELDR build option to loader: Add WITH/WITHOUT_LOADER_PXEBOOT build option.Aug 2 2024, 11:33 PM
imp edited the summary of this revision. (Show Details)
imp updated this revision to Diff 141757.Aug 2 2024, 11:37 PM

update per review, mostly ldr->boot

Harbormaster completed remote builds in B58927: Diff 141757.Aug 2 2024, 11:37 PM
imp added inline comments.Aug 2 2024, 11:38 PM
tools/build/options/WITH_LOADER_PXELDR
1 ↗(On Diff #141742)

pkeldr is the loader that lives inside of pxeboot.

But most people just know about pxeboot, so I'm renaming the new args to match.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 6 2024, 11:30 PM
Closed by commit rG20d35d581785: loader: Add WITH/WITHOUT_LOADER_PXEBOOT build option (authored by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG20d35d581785: loader: Add WITH/WITHOUT_LOADER_PXEBOOT build option.
imp added a commit: rGe179ee000ef2: loader: Add WITH/WITHOUT_LOADER_PXEBOOT build option.Aug 13 2024, 5:32 PM

Revision Contents
Changeset List

PathSize
share/
mk/
1 line
stand/
i386/
2 lines
tools/
build/
options/
10 lines
25 lines

Diff 141874

View Options

share/mk/src.opts.mk

Loading...
View Options

stand/i386/Makefile

Loading...
View Options

tools/build/options/WITHOUT_LOADER_PXEBOOT

Loading...
View Options

tools/build/options/WITH_LOADER_PXEBOOT

Loading...