Page MenuHomeFreeBSD
Differential D44843

Remove the MK_NVME build option
ClosedPublic
Actions

Authored by jhb on Apr 18 2024, 5:44 PM.
Tags
None
Referenced Files
F143720840: D44843.diff
Sat, Jan 31, 8:53 AM
F143636294: D44843.diff
Sat, Jan 31, 3:23 AM
F143540787: D44843.id137572.diff
Fri, Jan 30, 9:16 PM
Unknown Object (File)
Fri, Jan 2, 7:33 PM
Unknown Object (File)
Fri, Jan 2, 5:42 PM
Unknown Object (File)
Dec 31 2025, 11:32 PM
Unknown Object (File)
Dec 26 2025, 3:16 AM
Unknown Object (File)
Dec 11 2025, 9:03 AM
View All Files
Subscribers
bdrewery
dab
emaste

Details

Reviewers
imp
emaste
Commits
rG7b182a286d42: Remove the MK_NVME build option
rGee3187f6fa79: Remove the MK_NVME build option
Summary

The drivers and utilities are now built and installed unconditionally.

Sponsored by: Chelsio Communications

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Apr 18 2024, 5:44 PM
Herald added subscribers: dab, emaste, bdrewery. · View Herald TranscriptApr 18 2024, 5:44 PM
jhb requested review of this revision.Apr 18 2024, 5:44 PM
jhb added a parent revision: D44842: nvmecontrol: Always build instead of being conditional on WITH_NVME.
Harbormaster completed remote builds in B57182: Diff 137321.Apr 18 2024, 5:44 PM
jhb added a child revision: D44713: cam: Add a XPORT_NVMF for NVMe over Fabrics sims.Apr 18 2024, 5:44 PM
emaste accepted this revision.Apr 18 2024, 6:09 PM

this one can mention that there are no consumers of the build option left in the tree

This revision is now accepted and ready to land.Apr 18 2024, 6:09 PM
jhb edited the summary of this revision. (Show Details)Apr 18 2024, 7:00 PM

I will of course do a regen of src.conf.5 as a followup commit as well.

imp accepted this revision.Apr 18 2024, 10:35 PM
Closed by commit rGee3187f6fa79: Remove the MK_NVME build option (authored by jhb). · Explain WhyApr 23 2024, 6:49 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGee3187f6fa79: Remove the MK_NVME build option.
jhb added a commit: rG7b182a286d42: Remove the MK_NVME build option.Aug 27 2024, 6:07 PM

Revision Contents
Changeset List

PathSize
share/
mk/
1 line
tools/
build/
options/

Diff 137572

View Options

share/mk/src.opts.mk

Loading...
View Options

tools/build/options/WITHOUT_NVME

Loading...
View Options

tools/build/options/WITH_NVME

Loading...