Differential D43654

vtnet: Avoid ifdefs based on __NO_STRICT_ALIGNMENT
ClosedPublic
Actions

Authored by imp on Jan 29 2024, 8:53 PM.

Tags

None

Referenced Files

	F174709187: D43654.id133865.diff
	Mon, Oct 5, 9:29 AM

	F174657480: D43654.id133559.diff
	Mon, Oct 5, 12:28 AM

	Unknown Object (File)
	Sun, Oct 4, 5:17 PM

	Unknown Object (File)
	Sun, Oct 4, 4:31 AM

	Unknown Object (File)
	Thu, Oct 1, 7:28 PM

	Unknown Object (File)
	Thu, Oct 1, 4:20 AM

	Unknown Object (File)
	Wed, Sep 30, 6:59 PM

	Unknown Object (File)
	Wed, Sep 30, 5:29 PM

Subscribers

None

Details

Reviewers

bz
markm
bryanv

Commits

rG7c51748a443f: vtnet: Avoid ifdefs based on __NO_STRICT_ALIGNMENT
rG9ae56ea964c8: vtnet: Avoid ifdefs based on __NO_STRICT_ALIGNMENT
rGa9600913b4db: vtnet: Avoid ifdefs based on __NO_STRICT_ALIGNMENT
rG0ea4b4084845: vtnet: Avoid ifdefs based on __NO_STRICT_ALIGNMENT

Summary

Some platforms require an adjustment of the ethernet hearders. Rather
than make this be on __NO_STRICT_ALIGNMENT being defined, define
VTNET_ETHER_ALIGN to be either 0 or ETHER_ALIGN (aka 2). Add a test to
the if statements to only do them when != 0. This eliminates the #ifdef
sprinkled in the code, still communicates the intent and gives the same
compiled results.

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 55704
Build 52593: arc lint + arc unit

Event Timeline

imp requested review of this revision.Jan 29 2024, 8:53 PM

imp created this revision.

Harbormaster completed remote builds in B55696: Diff 133531.Jan 29 2024, 8:53 PM

imp added reviewers: bz, markm, bryanv.Jan 29 2024, 10:05 PM

bz added inline comments.Jan 29 2024, 10:43 PM

sys/dev/virtio/network/if_vtnet.c
95	s/2/ETHER_ALIGN/ to understand the magic number

imp added inline comments.Jan 29 2024, 11:00 PM

sys/dev/virtio/network/if_vtnet.c
95	Right. I'd meant to do that and has a braino

update to use ETHER_ALIGN

Harbormaster completed remote builds in B55704: Diff 133559.Jan 30 2024, 12:37 AM

bryanv accepted this revision.Jan 31 2024, 3:39 AM

This revision is now accepted and ready to land.Jan 31 2024, 3:39 AM

bz accepted this revision.Feb 1 2024, 11:33 AM

Closed by commit rG0ea4b4084845: vtnet: Avoid ifdefs based on __NO_STRICT_ALIGNMENT (authored by imp). · Explain WhyFeb 5 2024, 5:46 AM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG0ea4b4084845: vtnet: Avoid ifdefs based on __NO_STRICT_ALIGNMENT.

imp added a commit: rGa9600913b4db: vtnet: Avoid ifdefs based on __NO_STRICT_ALIGNMENT.Feb 19 2024, 4:49 AM

imp added a commit: rG9ae56ea964c8: vtnet: Avoid ifdefs based on __NO_STRICT_ALIGNMENT.

imp added a commit: rG7c51748a443f: vtnet: Avoid ifdefs based on __NO_STRICT_ALIGNMENT.Feb 19 2024, 7:00 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

virtio/

network/

24 lines

Diff 133559

sys/dev/virtio/network/if_vtnet.c

Loading...