Page MenuHomeFreeBSD

vtnet: Avoid ifdefs based on __NO_STRICT_ALIGNMENT
ClosedPublic

Authored by imp on Jan 29 2024, 8:53 PM.
Tags
None
Referenced Files
F105600837: D43654.diff
Wed, Dec 18, 3:50 AM
Unknown Object (File)
Thu, Dec 5, 11:47 PM
Unknown Object (File)
Sat, Nov 23, 2:48 AM
Unknown Object (File)
Thu, Nov 21, 4:25 PM
Unknown Object (File)
Wed, Nov 20, 9:00 AM
Unknown Object (File)
Nov 8 2024, 7:30 AM
Unknown Object (File)
Nov 8 2024, 7:28 AM
Unknown Object (File)
Nov 8 2024, 6:11 AM
Subscribers
None

Details

Summary

Some platforms require an adjustment of the ethernet hearders. Rather
than make this be on __NO_STRICT_ALIGNMENT being defined, define
VTNET_ETHER_ALIGN to be either 0 or ETHER_ALIGN (aka 2). Add a test to
the if statements to only do them when != 0. This eliminates the #ifdef
sprinkled in the code, still communicates the intent and gives the same
compiled results.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Jan 29 2024, 8:53 PM
imp created this revision.
sys/dev/virtio/network/if_vtnet.c
95

s/2/ETHER_ALIGN/ to understand the magic number

sys/dev/virtio/network/if_vtnet.c
95

Right. I'd meant to do that and has a braino

update to use ETHER_ALIGN

This revision is now accepted and ready to land.Jan 31 2024, 3:39 AM