Page MenuHomeFreeBSD

vtnet: Avoid ifdefs based on __NO_STRICT_ALIGNMENT
ClosedPublic

Authored by imp on Jan 29 2024, 8:53 PM.
Tags
None
Referenced Files
F138036111: D43654.diff
Fri, Nov 28, 9:48 AM
Unknown Object (File)
Tue, Nov 25, 11:26 PM
Unknown Object (File)
Sun, Nov 16, 11:09 PM
Unknown Object (File)
Fri, Nov 7, 3:57 AM
Unknown Object (File)
Thu, Nov 6, 11:27 AM
Unknown Object (File)
Wed, Nov 5, 10:43 AM
Unknown Object (File)
Wed, Nov 5, 10:41 AM
Unknown Object (File)
Wed, Nov 5, 10:39 AM
Subscribers
None

Details

Summary

Some platforms require an adjustment of the ethernet hearders. Rather
than make this be on __NO_STRICT_ALIGNMENT being defined, define
VTNET_ETHER_ALIGN to be either 0 or ETHER_ALIGN (aka 2). Add a test to
the if statements to only do them when != 0. This eliminates the #ifdef
sprinkled in the code, still communicates the intent and gives the same
compiled results.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 55696
Build 52585: arc lint + arc unit

Event Timeline

imp requested review of this revision.Jan 29 2024, 8:53 PM
imp created this revision.
sys/dev/virtio/network/if_vtnet.c
95

s/2/ETHER_ALIGN/ to understand the magic number

sys/dev/virtio/network/if_vtnet.c
95

Right. I'd meant to do that and has a braino

update to use ETHER_ALIGN

This revision is now accepted and ready to land.Jan 31 2024, 3:39 AM