Page MenuHomeFreeBSD
Differential D43529

Add kern_openatfp(9)
ClosedPublic
Actions

Authored by kib on Jan 20 2024, 8:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 10 2025, 9:57 AM
Unknown Object (File)
Feb 10 2025, 1:05 PM
Unknown Object (File)
Feb 10 2025, 12:39 PM
Unknown Object (File)
Feb 9 2025, 8:49 PM
Unknown Object (File)
Feb 7 2025, 8:52 PM
Unknown Object (File)
Feb 7 2025, 8:14 PM
Unknown Object (File)
Feb 4 2025, 4:45 PM
Unknown Object (File)
Feb 4 2025, 4:45 PM
View All 62 Files
Subscribers
ae
glebius
imp
melifaro

Details

Reviewers
markj
pjd
Commits
rGc662306e19ce: Add kern_openatfp(9)
rG2a284076ecb4: kern_openat(): rename fd argument to dirfd
rG3d59b93b207e: kern_openat(): minor style fixes
Summary

See https://github.com/openzfs/zfs/pull/15630

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib created this revision.Jan 20 2024, 8:39 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 20 2024, 8:39 PM
kib requested review of this revision.Jan 20 2024, 8:39 PM
pjd requested changes to this revision.Jan 20 2024, 9:59 PM

Thank you for working on this!

sys/kern/vfs_syscalls.c
1247

Personally I'd just add 'return (0)' here and eliminate 'else' below, which would reduce the diff.

I also don't see '*fpp = fp' anywhere.

This revision now requires changes to proceed.Jan 20 2024, 9:59 PM
kib updated this revision to Diff 133105.Jan 20 2024, 10:14 PM
kib marked an inline comment as done.

Do assign *fpp.

Herald added subscribers: glebius, melifaro, ae. · View Herald TranscriptJan 20 2024, 10:14 PM
kib updated this revision to Diff 133106.Jan 20 2024, 10:15 PM

Fix diff generation.

pjd accepted this revision.Jan 20 2024, 10:21 PM
This revision is now accepted and ready to land.Jan 20 2024, 10:21 PM
markj added inline comments.Jan 22 2024, 2:51 PM
sys/kern/vfs_syscalls.c
1115
1288

Is there a specific scenario you are guarding against here?

kib marked 2 inline comments as done.Jan 22 2024, 10:00 PM
kib added inline comments.
sys/kern/vfs_syscalls.c
1288

Recursing into VFS, which we sort of explicitly enable there with a backdoor into filesystem driver VOP_CREATE/VOP_OPEN.

It is similar how td_fpop is handled for devfs, to avoid unlikely but hard to diagnose surprises.

markj accepted this revision.Jan 23 2024, 2:33 PM
Closed by commit rG3d59b93b207e: kern_openat(): minor style fixes (authored by kib). · Explain WhyJan 24 2024, 5:13 AM
This revision was automatically updated to reflect the committed changes.
kib marked an inline comment as done.
kib added a commit: rG3d59b93b207e: kern_openat(): minor style fixes.
kib added a commit: rG2a284076ecb4: kern_openat(): rename fd argument to dirfd.
kib added a commit: rGc662306e19ce: Add kern_openatfp(9).
GitHub <noreply@github.com> mentioned this in rGa4bf6baaeb70: Fix file descriptor leak on pool import..Jan 24 2024, 11:39 AM
Brian Behlendorf <behlendorf1@llnl.gov> mentioned this in rG3425484eb907: Fix file descriptor leak on pool import..Feb 23 2024, 10:40 AM

Revision Contents
Changeset List

PathSize
sys/
kern/
47 lines
modules/
ipsec/
4 lines
netipsec/
4 lines
sys/
4 lines

Diff 133105

View Options

sys/kern/vfs_syscalls.c

Show All 32 Lines
#include <sys/capsicum.h> #include <sys/capsicum.h>
#include <sys/disk.h> #include <sys/disk.h>
#include <sys/ioctl.h> #include <sys/ioctl.h>
#include <sys/stat.h> #include <sys/stat.h>
#include <err.h> #include <err.h>
#include <errno.h> #include <errno.h>
#include <stdbool.h> #include <stdbool.h>
#include <stddef.h>
#include <stdint.h> #include <stdint.h>
#include <stdio.h> #include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
#include <string.h> #include <string.h>
#include <unistd.h> #include <unistd.h>
#include <vis.h> #include <vis.h>
#include "fstyp.h" #include "fstyp.h"
▲ Show 20 Lines • Show All 48 Lines • ▼ Show 20 Lines
checked_strdup(const char *s) checked_strdup(const char *s)
{ {
char *c; char *c;
c = strdup(s); c = strdup(s);
if (c == NULL) if (c == NULL)
err(1, "strdup"); err(1, "strdup");
return (c); return (c);
}
void
trim(char *label, size_t size)
emasteUnsubmitted
Not Done
Inline Actions

Perhaps call this rtrim instead. There's a precedent in various languages for ltrim/rtrim/trim, with trim removing both leading and trailing space.

emaste: Perhaps call this rtrim instead. There's a precedent in various languages for ltrim/rtrim/trim…
{
ptrdiff_t i;
for (i = size - 1; i >= 0; i--) {
if (label[i] == '\0')
continue;
else if (label[i] == ' ')
label[i] = '\0';
else
break;
}
} }
static void static void
usage(void) usage(void)
{ {
fprintf(stderr, "usage: fstyp [-l][-s] special\n"); fprintf(stderr, "usage: fstyp [-l][-s] special\n");
exit(1); exit(1);
▲ Show 20 Lines • Show All 98 Lines • Show Last 20 Lines
View Options

sys/modules/ipsec/Makefile

Show All 32 Lines
#include <sys/capsicum.h> #include <sys/capsicum.h>
#include <sys/disk.h> #include <sys/disk.h>
#include <sys/ioctl.h> #include <sys/ioctl.h>
#include <sys/stat.h> #include <sys/stat.h>
#include <err.h> #include <err.h>
#include <errno.h> #include <errno.h>
#include <stdbool.h> #include <stdbool.h>
#include <stddef.h>
#include <stdint.h> #include <stdint.h>
#include <stdio.h> #include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
#include <string.h> #include <string.h>
#include <unistd.h> #include <unistd.h>
#include <vis.h> #include <vis.h>
#include "fstyp.h" #include "fstyp.h"
▲ Show 20 Lines • Show All 48 Lines • ▼ Show 20 Lines
checked_strdup(const char *s) checked_strdup(const char *s)
{ {
char *c; char *c;
c = strdup(s); c = strdup(s);
if (c == NULL) if (c == NULL)
err(1, "strdup"); err(1, "strdup");
return (c); return (c);
}
void
trim(char *label, size_t size)
emasteUnsubmitted
Not Done
Inline Actions

Perhaps call this rtrim instead. There's a precedent in various languages for ltrim/rtrim/trim, with trim removing both leading and trailing space.

emaste: Perhaps call this rtrim instead. There's a precedent in various languages for ltrim/rtrim/trim…
{
ptrdiff_t i;
for (i = size - 1; i >= 0; i--) {
if (label[i] == '\0')
continue;
else if (label[i] == ' ')
label[i] = '\0';
else
break;
}
} }
static void static void
usage(void) usage(void)
{ {
fprintf(stderr, "usage: fstyp [-l][-s] special\n"); fprintf(stderr, "usage: fstyp [-l][-s] special\n");
exit(1); exit(1);
▲ Show 20 Lines • Show All 98 Lines • Show Last 20 Lines
View Options

sys/netipsec/ipsec_support.h

Show All 32 Lines
#include <sys/capsicum.h> #include <sys/capsicum.h>
#include <sys/disk.h> #include <sys/disk.h>
#include <sys/ioctl.h> #include <sys/ioctl.h>
#include <sys/stat.h> #include <sys/stat.h>
#include <err.h> #include <err.h>
#include <errno.h> #include <errno.h>
#include <stdbool.h> #include <stdbool.h>
#include <stddef.h>
#include <stdint.h> #include <stdint.h>
#include <stdio.h> #include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
#include <string.h> #include <string.h>
#include <unistd.h> #include <unistd.h>
#include <vis.h> #include <vis.h>
#include "fstyp.h" #include "fstyp.h"
▲ Show 20 Lines • Show All 48 Lines • ▼ Show 20 Lines
checked_strdup(const char *s) checked_strdup(const char *s)
{ {
char *c; char *c;
c = strdup(s); c = strdup(s);
if (c == NULL) if (c == NULL)
err(1, "strdup"); err(1, "strdup");
return (c); return (c);
}
void
trim(char *label, size_t size)
emasteUnsubmitted
Not Done
Inline Actions

Perhaps call this rtrim instead. There's a precedent in various languages for ltrim/rtrim/trim, with trim removing both leading and trailing space.

emaste: Perhaps call this rtrim instead. There's a precedent in various languages for ltrim/rtrim/trim…
{
ptrdiff_t i;
for (i = size - 1; i >= 0; i--) {
if (label[i] == '\0')
continue;
else if (label[i] == ' ')
label[i] = '\0';
else
break;
}
} }
static void static void
usage(void) usage(void)
{ {
fprintf(stderr, "usage: fstyp [-l][-s] special\n"); fprintf(stderr, "usage: fstyp [-l][-s] special\n");
exit(1); exit(1);
▲ Show 20 Lines • Show All 98 Lines • Show Last 20 Lines
View Options

sys/sys/syscallsubr.h

Show All 32 Lines
#include <sys/capsicum.h> #include <sys/capsicum.h>
#include <sys/disk.h> #include <sys/disk.h>
#include <sys/ioctl.h> #include <sys/ioctl.h>
#include <sys/stat.h> #include <sys/stat.h>
#include <err.h> #include <err.h>
#include <errno.h> #include <errno.h>
#include <stdbool.h> #include <stdbool.h>
#include <stddef.h>
#include <stdint.h> #include <stdint.h>
#include <stdio.h> #include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
#include <string.h> #include <string.h>
#include <unistd.h> #include <unistd.h>
#include <vis.h> #include <vis.h>
#include "fstyp.h" #include "fstyp.h"
▲ Show 20 Lines • Show All 48 Lines • ▼ Show 20 Lines
checked_strdup(const char *s) checked_strdup(const char *s)
{ {
char *c; char *c;
c = strdup(s); c = strdup(s);
if (c == NULL) if (c == NULL)
err(1, "strdup"); err(1, "strdup");
return (c); return (c);
}
void
trim(char *label, size_t size)
emasteUnsubmitted
Not Done
Inline Actions

Perhaps call this rtrim instead. There's a precedent in various languages for ltrim/rtrim/trim, with trim removing both leading and trailing space.

emaste: Perhaps call this rtrim instead. There's a precedent in various languages for ltrim/rtrim/trim…
{
ptrdiff_t i;
for (i = size - 1; i >= 0; i--) {
if (label[i] == '\0')
continue;
else if (label[i] == ' ')
label[i] = '\0';
else
break;
}
} }
static void static void
usage(void) usage(void)
{ {
fprintf(stderr, "usage: fstyp [-l][-s] special\n"); fprintf(stderr, "usage: fstyp [-l][-s] special\n");
exit(1); exit(1);
▲ Show 20 Lines • Show All 98 Lines • Show Last 20 Lines