Paths

Table of Contentst

Stop using expressions in _Alignof()
ClosedPublic
Actions

Authored by minsoochoo0122_proton.me on Jan 12 2024, 3:42 AM.

Details

Reviewers

andrew
manu
imp
arichardson
jhb

Group Reviewers

Contributor Reviews (src)

Commits

rG2bc1e37e1d83: Stop using expressions in _Alignof()
rG3b2b83bcef04: Stop using expressions in _Alignof()
rG03d04bf49492: Stop using expressions in _Alignof()

Summary

Divide from D43239

_Alignof(expression) is a non-standard extension (https://en.cppreference.com/w/c/language/_Alignof).
This is not allowed in gnu11 and gnu17 which follow the C11 standard _Alignof(type).

Test Plan

make buildkernel

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 55382
Build 52271: arc lint + arc unit

Event Timeline

minsoochoo0122_proton.me created this revision.Jan 12 2024, 3:42 AM

Herald added a reviewer: andrew. · View Herald TranscriptJan 12 2024, 3:42 AM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added subscribers: riscv, emaste, imp. · View Herald Transcript

minsoochoo0122_proton.me requested review of this revision.Jan 12 2024, 3:42 AM

Harbormaster completed remote builds in B55382: Diff 132651.Jan 12 2024, 3:42 AM

minsoochoo0122_proton.me added a reviewer: Contributor Reviews (src).Jan 12 2024, 3:42 AM

minsoochoo0122_proton.me added a project: Contributor Reviews (src).

minsoochoo0122_proton.me added a child revision: D43239: Use gnu17 for buildkernel.

minsoochoo0122_proton.me added a subscriber: Contributor Reviews (src).

imp accepted this revision.Jan 12 2024, 3:45 AM

This revision is now accepted and ready to land.Jan 12 2024, 3:45 AM

minsoochoo0122_proton.me edited the summary of this revision. (Show Details)Jan 12 2024, 3:46 AM

minsoochoo0122_proton.me mentioned this in D43239: Use gnu17 for buildkernel.Jan 12 2024, 3:48 AM

arichardson accepted this revision.Jan 12 2024, 4:06 AM

Diff itself is fine, but the amended summary isn't a helpful commit message

minsoochoo0122_proton.me edited the summary of this revision. (Show Details)Jan 12 2024, 5:05 AM

Please wrap the commit message at 80 columns. Otherwise it looks much better.

Sorry, just spotted one style issue

sys/amd64/amd64/db_trace.c
208	This line is now too long

Oh how I wish I could run even the kinda whiny checkstyle9.pl in phabricator :(.

style(9)

This revision now requires review to proceed.Jan 12 2024, 6:16 AM

Harbormaster completed remote builds in B55386: Diff 132658.Jan 12 2024, 6:16 AM

minsoochoo0122_proton.me marked an inline comment as done.Jan 12 2024, 6:16 AM

minsoochoo0122_proton.me edited the summary of this revision. (Show Details)Jan 12 2024, 6:19 AM

Fix commit message

Harbormaster completed remote builds in B55399: Diff 132704.Jan 12 2024, 9:49 PM

I will add a Fixes: tag to reference my original commit to the log message when merging this. Also, no need to mention the other review (first sentence) in the commit log so I will elide that as well.

This revision is now accepted and ready to land.Jan 12 2024, 11:19 PM

Closed by commit rG03d04bf49492: Stop using expressions in _Alignof() (authored by minsoochoo0122_proton.me, committed by jhb). · Explain WhyJan 12 2024, 11:42 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG03d04bf49492: Stop using expressions in _Alignof().

minsoochoo0122_proton.me removed a child revision: D43239: Use gnu17 for buildkernel.Apr 6 2024, 12:29 AM

jhb added a commit: rG3b2b83bcef04: Stop using expressions in _Alignof().Apr 8 2024, 7:05 PM

jhb added a commit: rG2bc1e37e1d83: Stop using expressions in _Alignof().Apr 8 2024, 8:26 PM