Page MenuHomeFreeBSD
Differential D43085

tcp: properly unroll sack transmission on tx error with LRD
ClosedPublic
Actions

Authored by rscheff on Dec 18 2023, 11:25 AM.
Tags
None
Referenced Files
F126771186: D43085.id131520.diff
Sat, Aug 23, 7:53 PM
Unknown Object (File)
Jul 3 2025, 9:40 AM
Unknown Object (File)
Jun 24 2025, 3:24 PM
Unknown Object (File)
Jun 11 2025, 11:10 PM
Unknown Object (File)
Jun 10 2025, 10:02 PM
Unknown Object (File)
May 8 2025, 8:07 AM
Unknown Object (File)
May 5 2025, 12:33 PM
Unknown Object (File)
Apr 23 2025, 5:16 PM
View All 66 Files
Subscribers
glebius
imp
melifaro

Details

Reviewers
cc
tuexen
thj
olivier
rrs
Group Reviewers
transport
Commits
rGac83f3fa44f3: tcp: properly unroll SACK transmission on TX error with LRD
rGe3b9058e5cd0: tcp: properly unroll sack transmission on tx error with LRD
Summary

While going over the code looing at PR275798, I spotted that
with LRD the rewind of the sackhole retransmission pointer
would not necessarily be calculcated correctly. In particular
with LRD, we point to snd_recover when a hole is fully retransmitted.
Need to account for that in case of a local transmission error.

PR: 275798
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 54985
Build 51874: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sys/
netinet/
2 lines

Diff 131519

View Options

sys/netinet/tcp_output.c

Loading...