Page MenuHomeFreeBSD

pf: remove DIOCGETRULE and DIOCGETSTATUS
ClosedPublic

Authored by kp on Aug 30 2023, 12:24 PM.
Tags
None
Referenced Files
F163590253: D41651.id.diff
Fri, Jul 24, 6:46 PM
Unknown Object (File)
Mon, Jul 20, 8:55 AM
Unknown Object (File)
Thu, Jul 16, 2:16 AM
Unknown Object (File)
Tue, Jul 7, 5:32 AM
Unknown Object (File)
Mon, Jul 6, 10:39 PM
Unknown Object (File)
Jun 6 2026, 4:32 PM
Unknown Object (File)
May 21 2026, 10:23 PM
Unknown Object (File)
May 20 2026, 8:00 AM

Details

Summary

These calls have nvlist variants that completely supersede them.
Remove the old code.

MFC after: never
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 53342
Build 50233: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Aug 30 2023, 12:53 PM
This revision was automatically updated to reflect the committed changes.

This leads the port net/py-libdnet to be broken:

--- fw-pf.lo ---
fw-pf.c:212:22: error: use of undeclared identifier 'DIOCGETRULE'
                        if (ioctl(fw->fd, DIOCGETRULE, &pcr) == 0 &&
                                          ^
fw-pf.c:252:22: error: use of undeclared identifier 'DIOCGETRULE'
                        if (ioctl(fw->fd, DIOCGETRULE, &pcr) == 0 &&
                                          ^
--- intf.lo ---
                for (cnt = 0; !matched && cnt < (int) entry->intf_alias_num; cnt++) {
                ^
intf.c:571:2: note: previous statement is here
        if (entry->intf_addr.addr_type == ADDR_TYPE_IP &&
        ^
--- fw-pf.lo ---
fw-pf.c:296:28: error: use of undeclared identifier 'DIOCGETRULE'
                if ((ret = ioctl(fw->fd, DIOCGETRULE, &pr)) < 0)
                                         ^
3 errors generated.

That leads to:

[00:00:41] [29] [00:00:26] Finished net/py-libdnet@py39 | py39-libdnet-1.13_4: Failed: build
[00:00:42] [29] [00:00:27] Skipping net/scapy@py39 | py39-scapy-2.5.0_1: Dependent port net/py-libdnet@py39 | py39-libdnet-1.13_4 failed

net/scapy is used by parts of the kyua testsuite (when installed, anyway).

This broke ftp/ftpsesame, which should probably be removed either way.