Page MenuHomeFreeBSD
Differential D41157

dtrace: Add WITH_DTRACE_ASAN.
ClosedPublic
Actions

Authored by domagoj.stolfa_gmail.com on Jul 23 2023, 2:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 20, 7:10 PM
Unknown Object (File)
Sun, Sep 20, 6:40 PM
Unknown Object (File)
Sun, Sep 20, 6:14 PM
Unknown Object (File)
Sun, Sep 20, 6:14 PM
Unknown Object (File)
Sun, Sep 20, 6:10 PM
Unknown Object (File)
Sun, Sep 20, 5:44 PM
Unknown Object (File)
Sun, Sep 20, 4:36 PM
Unknown Object (File)
Mon, Sep 7, 11:17 PM
View All Files
Subscribers
bdrewery
emaste
imp

Details

Reviewers
markj
gnn
Commits
rG4ae699122810: dtrace: Add WITH_DTRACE_ASAN
Summary

This option is a blanket for all the DTrace-related software. The option
enables passes in -fsanitize=address -fsanitize=undefined, enabling ASAN
and UBSAN in the following components:

  • libdtrace
  • dtrace(1)
  • lockstat(1)
  • plockstat(1)

The option defaults to "no" and is intended as a developer aid.

Test Plan

Apply this patch, echo 'WITH_DTRACE_ASAN=' >> /etc/src.conf and rebuild.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 52803
Build 49694: arc lint + arc unit

Event Timeline

domagoj.stolfa_gmail.com created this revision.Jul 23 2023, 2:51 PM
Herald added a reviewer: gnn. · View Herald TranscriptJul 23 2023, 2:51 PM
Herald added subscribers: emaste, imp, bdrewery. · View Herald Transcript
domagoj.stolfa_gmail.com requested review of this revision.Jul 23 2023, 2:51 PM
markj added a comment.Jul 24 2023, 1:49 PM

This is missing an option description, i.e., tools/build/options/WITH_DTRACE_ASAN needs to be added.

Harbormaster completed remote builds in B52796: Diff 125054.Jul 24 2023, 6:19 PM
domagoj.stolfa_gmail.com updated this revision to Diff 125087.Jul 24 2023, 7:04 PM

Add tools/build/options/WITH_DTRACE_ASAN and update src.conf.

If there's any other preference for the text that should be contained in the man pages, I would be happy to replace it.

Harbormaster completed remote builds in B52803: Diff 125087.Jul 24 2023, 7:04 PM
markj accepted this revision.Jul 25 2023, 1:24 PM
markj added inline comments.
tools/build/options/WITH_DTRACE_ASAN
2
This revision is now accepted and ready to land.Jul 25 2023, 1:24 PM
emaste added inline comments.Jul 25 2023, 1:58 PM
tools/build/options/WITH_DTRACE_ASAN
1

$FreeBSD$ is no longer needed, you can leave it out

domagoj.stolfa_gmail.com updated this revision to Diff 125132.Jul 25 2023, 5:58 PM

Address the comments by markj and emaste.

This revision now requires review to proceed.Jul 25 2023, 5:58 PM
Harbormaster completed remote builds in B52819: Diff 125132.Jul 25 2023, 5:58 PM
domagoj.stolfa_gmail.com marked 2 inline comments as done.Jul 25 2023, 5:58 PM
domagoj.stolfa_gmail.com updated this revision to Diff 125138.Jul 25 2023, 6:59 PM

Remove a leftover .\".

Harbormaster completed remote builds in B52823: Diff 125138.Jul 25 2023, 6:59 PM
domagoj.stolfa_gmail.com updated this revision to Diff 125139.Jul 25 2023, 7:07 PM

Add a missing newline to the option file and regenerate src.conf.5.

Harbormaster completed remote builds in B52824: Diff 125139.Jul 25 2023, 7:07 PM
markj accepted this revision.Jul 26 2023, 2:34 PM
This revision is now accepted and ready to land.Jul 26 2023, 2:34 PM
markj added a comment.Jul 26 2023, 2:35 PM

Could you please mail me a git diff to apply to main?

Closed by commit rG4ae699122810: dtrace: Add WITH_DTRACE_ASAN (authored by domagoj.stolfa_gmail.com, committed by markj). · Explain WhyJul 27 2023, 8:13 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG4ae699122810: dtrace: Add WITH_DTRACE_ASAN.

Revision Contents
Changeset List

PathSize
cddl/
lib/
libdtrace/
7 lines
usr.sbin/
dtrace/
5 lines
lockstat/
7 lines
plockstat/
7 lines
share/
man/
man5/
mk/
1 line
tools/
build/
options/
4 lines

Diff 125087

View Options

cddl/lib/libdtrace/Makefile

Loading...
View Options

cddl/usr.sbin/dtrace/Makefile

Loading...
View Options

cddl/usr.sbin/lockstat/Makefile

Loading...
View Options

cddl/usr.sbin/plockstat/Makefile

Loading...
View Options

share/man/man5/src.conf.5

Loading...
View Options

share/mk/src.opts.mk

Loading...
View Options

tools/build/options/WITH_DTRACE_ASAN

Loading...