Page MenuHomeFreeBSD

netinet[6]: make in[6]_control use ucred instead of td
ClosedPublic

Authored by melifaro on Jun 29 2023, 7:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 3, 9:03 AM
Unknown Object (File)
Fri, Oct 3, 5:06 AM
Unknown Object (File)
Fri, Oct 3, 4:43 AM
Unknown Object (File)
Tue, Sep 30, 11:32 AM
Unknown Object (File)
Sep 14 2025, 6:01 PM
Unknown Object (File)
Sep 11 2025, 4:26 AM
Unknown Object (File)
Sep 8 2025, 10:43 AM
Unknown Object (File)
Aug 26 2025, 7:41 PM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 52324
Build 49215: arc lint + arc unit

Event Timeline

markj added a subscriber: markj.

Not directly related to the patch, but: nl_pru_attach() does not count its ucred reference, i.e., it does not use crhold() when copying the socket's reference. However, nl_pru_detach() uses a deferred free and does not set nl_cred = NULL before returning to sodealloc(), which releases the ucred reference, so there is a window where netlink holds a dangling ucred reference.

This revision is now accepted and ready to land.Jun 29 2023, 2:40 PM
zlei added a subscriber: zlei.

I'm not familiar with the netlink part, others look good to me.