Page MenuHomeFreeBSD
Differential D40542

hwpmc(4): more detailed SYNOPSYS
ClosedPublic
Actions

Authored by mhorne on Jun 14 2023, 5:58 PM.
Tags
None
Referenced Files
F153426669: D40542.id123244.diff
Tue, Apr 21, 2:48 AM
F153424416: D40542.id.diff
Tue, Apr 21, 2:29 AM
F153322025: D40542.id123346.diff
Mon, Apr 20, 11:30 AM
F153299313: D40542.diff
Mon, Apr 20, 8:14 AM
F153266580: D40542.id123239.diff
Mon, Apr 20, 3:47 AM
Unknown Object (File)
Mon, Apr 20, 12:43 AM
Unknown Object (File)
Sun, Apr 19, 9:46 PM
Unknown Object (File)
Sat, Apr 18, 11:54 AM
View All Files
Subscribers
imp

Details

Reviewers
jkoshy
emaste
gnn
Group Reviewers
pmc
manpages
Commits
rG387ee93e0794: hwpmc(4): more detailed SYNOPSYS
rG0a1a48148ccd: hwpmc(4): more detailed SYNOPSYS
Summary

Include some boilerplate similar to other section 4 man pages,
describing how to load the module at boot-time or include it in the
kernel.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 52059
Build 48950: arc lint + arc unit

Event Timeline

mhorne created this revision.Jun 14 2023, 5:58 PM
Herald added a reviewer: gnn. · View Herald TranscriptJun 14 2023, 5:58 PM
Herald added a subscriber: imp. · View Herald Transcript
mhorne requested review of this revision.Jun 14 2023, 5:58 PM
Harbormaster completed remote builds in B52055: Diff 123239.Jun 14 2023, 5:58 PM
mhorne added a parent revision: D40541: hwpmc(4): remove paragraph about Pentium Pro handling.Jun 14 2023, 5:58 PM
mhorne added a child revision: D40543: pmc: clarify and strengthen statements about API/ABI.
mhorne added a reviewer: manpages.Jun 14 2023, 6:00 PM
emaste added inline comments.Jun 14 2023, 6:28 PM
share/man/man4/hwpmc.4
48–52

should we suggest kld_list in rc.conf instead?

mhorne added inline comments.Jun 14 2023, 6:53 PM
share/man/man4/hwpmc.4
48–52

Yes I suppose so, there is no reason to have hwpmc loaded before then.

mhorne updated this revision to Diff 123244.Jun 14 2023, 6:56 PM

Switch to kld_list.

Harbormaster completed remote builds in B52059: Diff 123244.Jun 14 2023, 6:56 PM
jkoshy added inline comments.Jun 14 2023, 7:35 PM
share/man/man4/hwpmc.4
31

Needs a bump of the date I think.

emaste accepted this revision.Jun 14 2023, 8:04 PM

as an aside I wish sh supported += :)

This revision is now accepted and ready to land.Jun 14 2023, 8:04 PM
jkoshy requested changes to this revision.Jun 14 2023, 8:09 PM
This revision now requires changes to proceed.Jun 14 2023, 8:09 PM
mhorne marked an inline comment as done.Jun 15 2023, 1:30 PM
mhorne added inline comments.
share/man/man4/hwpmc.4
31

Yes, I currently have the bump in D40543.

jkoshy accepted this revision.Jun 16 2023, 4:04 AM
This revision is now accepted and ready to land.Jun 16 2023, 4:04 AM
Closed by commit rG0a1a48148ccd: hwpmc(4): more detailed SYNOPSYS (authored by mhorne). · Explain WhyJun 16 2023, 4:45 PM
This revision was automatically updated to reflect the committed changes.
mhorne marked an inline comment as done.
mhorne added a commit: rG0a1a48148ccd: hwpmc(4): more detailed SYNOPSYS.
mhorne added a commit: rG387ee93e0794: hwpmc(4): more detailed SYNOPSYS.Jul 17 2023, 4:49 PM

Revision Contents
Changeset List

PathSize
share/
man/
man4/
18 lines

Diff 123244

View Options

share/man/man4/hwpmc.4

Loading...