hwpmc_mod.c: misc style cleanup
ClosedPublic
Actions

Authored by mhorne on Jun 13 2023, 5:55 PM.

Details

Reviewers

jkoshy
gnn

Commits

rG01c35b677fde: hwpmc_mod.c: misc style cleanup

Summary

Everything else I found worthy of adjustment.

Order local variable declarations per style(9)
Make use of __unused annotations rather than cast to void
Remove unnecessary casts
Add (void) casts to PMC class methods where the return value is ignored
A couple instances of reordering statements for clarity
Prefer bool type where applicable
unsigned int -> u_int
Use uintmax_t/%j in printf calls
Formatting of comments

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 52026
Build 48917: arc lint + arc unit

Event Timeline

mhorne created this revision.Jun 13 2023, 5:55 PM

Herald added a reviewer: gnn. · View Herald TranscriptJun 13 2023, 5:55 PM

Herald added a subscriber: imp. · View Herald Transcript

mhorne requested review of this revision.Jun 13 2023, 5:55 PM

Harbormaster completed remote builds in B52026: Diff 123165.Jun 13 2023, 5:55 PM

jkoshy accepted this revision.Jun 14 2023, 9:58 AM

This revision is now accepted and ready to land.Jun 14 2023, 9:58 AM

Closed by commit rG01c35b677fde: hwpmc_mod.c: misc style cleanup (authored by mhorne). · Explain WhyJun 14 2023, 4:47 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rG01c35b677fde: hwpmc_mod.c: misc style cleanup.

mhorne mentioned this in D40289: hwpmc: style(9) pass of hwpmc_mod.c.Jun 14 2023, 4:49 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

hwpmc/

hwpmc_mod.c

448 lines

Diff 123165

View Options

hwpmc_mod.c: misc style cleanupClosedPublicActions