Page MenuHomeFreeBSD
Differential D39234

tcp: update error counter when dropping a packet due to bad source
ClosedPublic
Actions

Authored by glebius on Mar 23 2023, 9:54 PM.
Tags
None
Referenced Files
F169193980: D39234.id119539.diff
Mon, Aug 31, 6:58 PM
Unknown Object (File)
Mon, Aug 31, 8:46 AM
Unknown Object (File)
Mon, Aug 31, 4:30 AM
Unknown Object (File)
Sun, Aug 30, 7:21 AM
Unknown Object (File)
Sat, Aug 29, 2:43 AM
Unknown Object (File)
Thu, Aug 27, 2:47 AM
Unknown Object (File)
Wed, Aug 26, 11:11 AM
Unknown Object (File)
Tue, Aug 25, 11:34 AM
View All Files
Subscribers
imp
melifaro
tuexen
zlei

Details

Reviewers
rrs
gallatin
markj
Group Reviewers
network
transport
Commits
rG78e6c3aacc7f: tcp: update error counter when dropping a packet due to bad source
Summary

Use the same counter that ip_input()/ip6_input() use for bad destination
address. For IPv6 this is already heavily abused ip6s_badscope, which
needs to be split into several separate error counters.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

glebius created this revision.Mar 23 2023, 9:54 PM
Herald added a reviewer: transport. · View Herald TranscriptMar 23 2023, 9:54 PM
Herald added subscribers: melifaro, imp. · View Herald Transcript
glebius requested review of this revision.Mar 23 2023, 9:54 PM
glebius added a child revision: D39235: LRO: improve IPv4/IPv6 packet header checks.
Harbormaster completed remote builds in B50549: Diff 119358.Mar 23 2023, 9:54 PM
tuexen added a subscriber: tuexen.Mar 24 2023, 8:58 AM
tuexen added inline comments.
sys/netinet/tcp_input.c
678

Why do you keep the /* XXX */ in one case, but not in the other. I suggest to be consistent.

markj accepted this revision as: markj.Mar 24 2023, 4:50 PM
markj added inline comments.
sys/netinet/tcp_input.c
678

For v4, badaddr seems like a reasonable counter. Here, the use of badscope is overloaded, I believe the XXX comment indicates that this is not the right counter. However, it's better than not counting at all.

zlei added a subscriber: zlei.Mar 24 2023, 4:50 PM
glebius added inline comments.Mar 25 2023, 12:55 AM
sys/netinet/tcp_input.c
678

Yes, exactly what Mark said. :)

This revision was not accepted when it landed; it landed in state Needs Review.Mar 28 2023, 1:38 AM
Closed by commit rG78e6c3aacc7f: tcp: update error counter when dropping a packet due to bad source (authored by glebius). · Explain Why
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rG78e6c3aacc7f: tcp: update error counter when dropping a packet due to bad source.

Revision Contents
Changeset List

PathSize
sys/
netinet/
4 lines

Diff 119539

View Options

sys/netinet/tcp_input.c

Loading...