Page MenuHomeFreeBSD
Differential D38283

netlink: return optional metadata with the operation result.
ClosedPublic
Actions

Authored by melifaro on Jan 30 2023, 6:40 PM.
Tags
None
Referenced Files
F170627948: D38283.id116102.diff
Sat, Sep 5, 5:20 PM
F170552988: D38283.id116102.diff
Sat, Sep 5, 9:21 AM
Unknown Object (File)
Fri, Sep 4, 6:57 PM
Unknown Object (File)
Fri, Sep 4, 5:36 PM
Unknown Object (File)
Thu, Sep 3, 9:05 PM
Unknown Object (File)
Thu, Sep 3, 8:31 PM
Unknown Object (File)
Wed, Sep 2, 5:29 PM
Unknown Object (File)
Wed, Sep 2, 4:39 PM
View All Files
Subscribers
ae
glebius
imp
pauamma_chezdork.com

Details

Reviewers
pauamma_chezdork.com
Group Reviewers
network
manpages
Commits
rG72467b39f1db: netlink: return optional metadata with the operation result.
rG25c2dd2f2c6c: netlink: return optional metadata with the operation result.
Summary

Some operations like interface creation may need to return metadata - in this case, interface name - back to the caller if the operation is successful.

This change implements attaching an NLMSGERR_ATTR_COOKIE nla to the operation reply message via nlmsg_report_cookie().
Additionally, on successful interface creation, interface index and interface name are returned in the IFLA_NEW_IFINDEX and IFLA_IFNAME TLVs, encapsulated in the NLMSGERR_ATTR_COOKIE`.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Errors
SeverityLocationCodeMessage
Errortests/atf_python/sys/net/netlink.py:599E501PEP8 E501
Errortests/atf_python/sys/net/netlink.py:813E501PEP8 E501
Errortests/atf_python/sys/net/netlink.py:865E203PEP8 E203
Errortests/atf_python/sys/net/netlink.py:867E203PEP8 E203
Errortests/atf_python/sys/net/netlink.py:939E701PEP8 E701
Errortests/atf_python/sys/net/netlink.py:940E701PEP8 E701
Errortests/atf_python/sys/net/netlink.py:941E701PEP8 E701
Errortests/atf_python/sys/net/netlink.py:1017E501PEP8 E501
Errortests/atf_python/sys/net/netlink.py:1133E501PEP8 E501
Errortests/atf_python/sys/net/netlink.py:1138E501PEP8 E501
Errortests/atf_python/sys/net/netlink.py:1149E203PEP8 E203
Errortests/atf_python/sys/net/netlink.py:1159E203PEP8 E203
Errortests/atf_python/sys/net/netlink.py:1159E501PEP8 E501
Errortests/atf_python/sys/net/netlink.py:1162E203PEP8 E203
Errortests/atf_python/sys/net/netlink.py:1162E501PEP8 E501
Errortests/atf_python/sys/net/netlink.py:1166E203PEP8 E203
Errortests/atf_python/sys/net/netlink.py:1439E203PEP8 E203
Errortests/sys/netlink/test_rtnl_iface.py:41E501PEP8 E501
Errortests/sys/netlink/test_rtnl_iface.py:77E501PEP8 E501
Errortests/sys/netlink/test_rtnl_iface.py:101E501PEP8 E501
Errortests/sys/netlink/test_rtnl_iface.py:117E501PEP8 E501
Errortests/sys/netlink/test_rtnl_iface.py:125E501PEP8 E501
Errortests/sys/netlink/test_rtnl_iface.py:133E501PEP8 E501
Errortests/sys/netlink/test_rtnl_iface.py:154E501PEP8 E501
Errortests/sys/netlink/test_rtnl_iface.py:163E501PEP8 E501
Unit
No Test Coverage
Build Status
Buildable 49334
Build 46224: arc lint + arc unit

Event Timeline

melifaro created this revision.Jan 30 2023, 6:40 PM
Herald added subscribers: glebius, ae, imp. · View Herald TranscriptJan 30 2023, 6:40 PM
melifaro requested review of this revision.Jan 30 2023, 6:40 PM
Harbormaster completed remote builds in B49334: Diff 116061.Jan 30 2023, 6:40 PM
melifaro edited the summary of this revision. (Show Details)Jan 30 2023, 6:41 PM
melifaro added a reviewer: network.
melifaro added a reviewer: manpages.
melifaro updated this revision to Diff 116102.Jan 31 2023, 1:40 PM

Fix python code formatting.

Harbormaster completed remote builds in B49352: Diff 116102.Jan 31 2023, 1:40 PM
pauamma_chezdork.com accepted this revision.Jan 31 2023, 6:01 PM
pauamma_chezdork.com added a subscriber: pauamma_chezdork.com.

Manual page change LGTM. Can't speak to consistency with source code.

This revision is now accepted and ready to land.Jan 31 2023, 6:01 PM
This revision was landed with ongoing or failed builds.Feb 9 2023, 3:30 PM
Closed by commit rG25c2dd2f2c6c: netlink: return optional metadata with the operation result. (authored by melifaro). · Explain Why
This revision was automatically updated to reflect the committed changes.
melifaro added a commit: rG25c2dd2f2c6c: netlink: return optional metadata with the operation result..
melifaro added a commit: rG72467b39f1db: netlink: return optional metadata with the operation result..Feb 20 2023, 2:34 PM

Revision Contents
Changeset List

PathSize
share/
man/
man4/
4 lines
7 lines
sys/
netlink/
4 lines
19 lines
31 lines
6 lines
route/
37 lines
tests/
atf_python/
sys/
net/
40 lines
sys/
netlink/
33 lines

Diff 116061

View Options

share/man/man4/netlink.4

Loading...
View Options

share/man/man4/rtnetlink.4

Loading...
View Options

sys/netlink/netlink_message_parser.h

Loading...
View Options

sys/netlink/netlink_message_parser.c

Loading...
View Options

sys/netlink/netlink_message_writer.h

Loading...
View Options

sys/netlink/netlink_message_writer.c

Loading...
View Options

sys/netlink/route/iface_drivers.c

Loading...
View Options

tests/atf_python/sys/net/netlink.py

Loading...
View Options

tests/sys/netlink/test_rtnl_iface.py

Loading...