Paths

Table of Contentst

Differential D38283

netlink: return optional metadata with the operation result.
ClosedPublic
Actions

Authored by melifaro on Jan 30 2023, 6:40 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jan 12, 9:03 AM

	Unknown Object (File)
	Sun, Jan 12, 9:02 AM

	Unknown Object (File)
	Sun, Jan 12, 9:02 AM

	Unknown Object (File)
	Sun, Jan 12, 9:02 AM

	Unknown Object (File)
	Sun, Jan 12, 5:47 AM

	Unknown Object (File)
	Thu, Jan 9, 1:26 PM

	Unknown Object (File)
	Sat, Dec 28, 9:32 PM

	Unknown Object (File)
	Dec 11 2024, 9:12 AM

View All 72 Files

Subscribers

pauamma_gundo.com

Details

Reviewers

pauamma_gundo.com

Group Reviewers

network
manpages

Commits

rG72467b39f1db: netlink: return optional metadata with the operation result.
rG25c2dd2f2c6c: netlink: return optional metadata with the operation result.

Summary

Some operations like interface creation may need to return metadata - in this case, interface name - back to the caller if the operation is successful.

This change implements attaching an NLMSGERR_ATTR_COOKIE nla to the operation reply message via nlmsg_report_cookie().
Additionally, on successful interface creation, interface index and interface name are returned in the IFLA_NEW_IFINDEX and IFLA_IFNAME TLVs, encapsulated in the NLMSGERR_ATTR_COOKIE`.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

melifaro created this revision.Jan 30 2023, 6:40 PM

Herald added subscribers: glebius, ae, imp. · View Herald TranscriptJan 30 2023, 6:40 PM

melifaro requested review of this revision.Jan 30 2023, 6:40 PM

Harbormaster completed remote builds in B49334: Diff 116061.Jan 30 2023, 6:40 PM

melifaro edited the summary of this revision. (Show Details)Jan 30 2023, 6:41 PM

melifaro added a reviewer: network.

melifaro added a reviewer: manpages.

Fix python code formatting.

Harbormaster completed remote builds in B49352: Diff 116102.Jan 31 2023, 1:40 PM

Manual page change LGTM. Can't speak to consistency with source code.

This revision is now accepted and ready to land.Jan 31 2023, 6:01 PM

This revision was landed with ongoing or failed builds.Feb 9 2023, 3:30 PM

Closed by commit rG25c2dd2f2c6c: netlink: return optional metadata with the operation result. (authored by melifaro). · Explain Why

This revision was automatically updated to reflect the committed changes.

melifaro added a commit: rG25c2dd2f2c6c: netlink: return optional metadata with the operation result..

melifaro added a commit: rG72467b39f1db: netlink: return optional metadata with the operation result..Feb 20 2023, 2:34 PM

Revision Contents
Changeset List

Path

Size

share/

man/

man4/

4 lines

7 lines

sys/

netlink/

netlink_message_parser.h

4 lines

netlink_message_parser.c

19 lines

netlink_message_writer.h

31 lines

netlink_message_writer.c

6 lines

route/

iface_drivers.c

37 lines

tests/

atf_python/

sys/

net/

134 lines

sys/

netlink/

test_rtnl_iface.py

35 lines

Diff 116846

share/man/man4/netlink.4

Loading...

share/man/man4/rtnetlink.4

Loading...

sys/netlink/netlink_message_parser.h

Loading...

sys/netlink/netlink_message_parser.c

Loading...

sys/netlink/netlink_message_writer.h

Loading...

sys/netlink/netlink_message_writer.c

Loading...

sys/netlink/route/iface_drivers.c

Loading...

tests/atf_python/sys/net/netlink.py

Loading...

tests/sys/netlink/test_rtnl_iface.py

Loading...