Page MenuHomeFreeBSD
Differential D36121

rtsock: do not allocate mbufs_tags(9) just to store a 8-bit value
ClosedPublic
Actions

Authored by glebius on Aug 10 2022, 7:22 PM.
Tags
None
Referenced Files
F167926890: D36121.id109121.diff
Tue, Aug 25, 11:30 AM
F167914661: D36121.id.diff
Tue, Aug 25, 10:05 AM
F167896546: D36121.id109121.diff
Tue, Aug 25, 7:53 AM
Unknown Object (File)
Mon, Aug 24, 4:49 AM
Unknown Object (File)
Mon, Aug 24, 4:04 AM
Unknown Object (File)
Sun, Aug 23, 3:51 AM
Unknown Object (File)
Wed, Aug 12, 1:57 PM
Unknown Object (File)
Wed, Aug 12, 11:25 AM
View All Files
Subscribers
ae
imp

Details

Reviewers
melifaro
Group Reviewers
network
Commits
rGd94ec7490d31: rtsock: do not allocate mbufs_tags(9) just to store a 8-bit value
Summary

Use local storage of the mbuf packet header instead.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 46838
Build 43727: arc lint + arc unit

Event Timeline

glebius created this revision.Aug 10 2022, 7:22 PM
Herald added subscribers: ae, imp. · View Herald TranscriptAug 10 2022, 7:22 PM
glebius requested review of this revision.Aug 10 2022, 7:22 PM
Harbormaster completed remote builds in B46838: Diff 109121.Aug 10 2022, 7:22 PM
glebius added a child revision: D36122: rtsock: do not use raw socket code.Aug 10 2022, 7:22 PM
melifaro accepted this revision.Aug 11 2022, 7:57 AM
melifaro added inline comments.
sys/net/rtsock.c
160

Nit: I'd rather name it something like m_rtsock_family to indicate that this is a local field.

This revision is now accepted and ready to land.Aug 11 2022, 7:57 AM
Closed by commit rGd94ec7490d31: rtsock: do not allocate mbufs_tags(9) just to store a 8-bit value (authored by glebius). · Explain WhyAug 11 2022, 4:20 PM
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rGd94ec7490d31: rtsock: do not allocate mbufs_tags(9) just to store a 8-bit value.

Revision Contents
Changeset List

PathSize
sys/
net/
33 lines
sys/
2 lines

Diff 109121

View Options

sys/net/rtsock.c

Loading...
View Options

sys/sys/mbuf.h

Loading...