Page MenuHomeFreeBSD
Differential D35916

stand: Add devformat to return formatted string for a device
ClosedPublic
Actions

Authored by imp on Jul 25 2022, 8:32 PM.
Tags
None
Referenced Files
F163224713: D35916.id108525.diff
Tue, Jul 21, 5:27 AM
Unknown Object (File)
Sun, Jul 19, 10:29 PM
Unknown Object (File)
Sat, Jul 4, 7:20 AM
Unknown Object (File)
Sat, Jul 4, 6:54 AM
Unknown Object (File)
Sat, Jul 4, 6:19 AM
Unknown Object (File)
Fri, Jul 3, 1:08 PM
Unknown Object (File)
Fri, Jul 3, 6:01 AM
Unknown Object (File)
Fri, Jul 3, 3:29 AM
View All Files
Subscribers
dab

Details

Reviewers
tsoome
kevans
manu
Commits
rG08939ccadc25: stand: Add devformat to return formatted string for a device
rGdc472f670213: stand: Add devformat to return formatted string for a device
Summary

Use dv_fmtdev to return a formatted string for a device. If this is a
null pointer, return the device name and unit followed by a colon (eg
disk3:).

Sponsored by: Netflix

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 46647
Build 43536: arc lint + arc unit

Event Timeline

imp created this revision.Jul 25 2022, 8:32 PM
Herald added a reviewer: manu. · View Herald TranscriptJul 25 2022, 8:32 PM
Herald added a subscriber: dab. · View Herald Transcript
imp requested review of this revision.Jul 25 2022, 8:32 PM
Harbormaster completed remote builds in B46561: Diff 108512.Jul 25 2022, 8:32 PM
imp added a parent revision: D35915: stand: Add dv_devfmt to return a string represenation of the device.Jul 25 2022, 8:32 PM
imp added a child revision: D35917: stand: Add disk_fmtdev for dv_fmtdev for all the disk devices.
tsoome accepted this revision.Jul 25 2022, 10:33 PM
tsoome added inline comments.
stand/libsa/dev.c
65

cstyle tells us: Test pointers against NULL

This revision is now accepted and ready to land.Jul 25 2022, 10:33 PM
imp updated this revision to Diff 108525.Jul 25 2022, 10:45 PM

Test against NULL

This revision now requires review to proceed.Jul 25 2022, 10:45 PM
Harbormaster completed remote builds in B46573: Diff 108525.Jul 25 2022, 10:45 PM
imp updated this revision to Diff 108654.Jul 28 2022, 4:57 PM

rebase

Harbormaster completed remote builds in B46647: Diff 108654.Jul 28 2022, 4:57 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 11 2022, 4:28 PM
Closed by commit rGdc472f670213: stand: Add devformat to return formatted string for a device (authored by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.
imp added a commit: rGdc472f670213: stand: Add devformat to return formatted string for a device.
imp added a commit: rG08939ccadc25: stand: Add devformat to return formatted string for a device.Jan 24 2023, 10:16 PM

Revision Contents
Changeset List

PathSize
stand/
libsa/
11 lines

Diff 108654

View Options

stand/libsa/dev.c

Loading...