Add the Arm CoreLink CMN-600 Coherent Mesh Network Controller PMU driver man page.
Sponsored By: ARM
Details
Details
- Reviewers
mhorne emaste andrew ray pauamma_gundo.com - Group Reviewers
manpages pmc - Commits
- rGda4e1e319c6c: Add the Arm CoreLink CMN-600 Coherent Mesh Network Controller PMU driver man…
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 46338 Build 43227: arc lint + arc unit
Event Timeline
Comment Actions
Could you ran 'mandoc -Tlint' over the man page. There are plenty of warnings, which could easily be fixed, like 'new sentence, new line' and so on. It would be nice if you could also add the author of the man page.
And you have to include this man page in the makefile of the directory.
Comment Actions
Most of the content is beyond me, but still have a few suggestions.
| lib/libpmc/pmc.cmn-600.3 | ||
|---|---|---|
| 42 | The capitalisation of "Id" here looks odd to me, but it may just be me. (In case it's not, I'd use either "ID" or "identifier".) | |
| 44–54 | Worth using Bl/El/It here for clarity? | |
| 176 | Spurious space after "-"? Also, does the intended audience for this know what "protocol-retried" means? | |
| 272 | ||
| 596 | Maybe include the manual page author as well, as shown in the vt(4) example in https://docs.freebsd.org/en/books/fdp-primer/manual-pages/#manual-pages-examples-as-templates ? | |