Paths

Table of Contentst

Enhance attachment of ehci_mv driver
ClosedPublic
Actions

Authored by bsz_semihalf.com on Dec 4 2015, 12:34 PM.

Details

Reviewers

andrew
imp
• ian

Commits

rS294427: Improve attachment of the ehci_mv driver

Summary

Driver was modified to ensure it attaches properly to "marvell,orion-ehci"
node, which doesn't have error interrupt line defined. Neccessary
ofw_compat_data struct was added and probe procedure was altered.

Obtained from: Semihalf
Sponsored by: Stormshield
Submitted by: Bartosz Szczepanek <bsz@semihalf.com>

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

bsz_semihalf.com updated this revision to Diff 10727.Dec 4 2015, 12:34 PM

bsz_semihalf.com retitled this revision from to Add "marvell,orion-ehci" compatible to ehci_mv driver.

bsz_semihalf.com updated this object.

bsz_semihalf.com edited the test plan for this revision. (Show Details)

bsz_semihalf.com added reviewers: • ian, imp.

bsz_semihalf.com set the repository for this revision to rS FreeBSD src repository - subversion.

bsz_semihalf.com added a parent revision: D4220: Enable SCU unit for Armada38x.

bsz_semihalf.com added a child revision: D4370: Add interrupt line for EHCI USB errors in Armada38x.

bsz_semihalf.com added a subscriber: zbb.

bsz_semihalf.com updated this object.Dec 4 2015, 12:45 PM

bsz_semihalf.com added a project: ARM.

bsz_semihalf.com updated this revision to Diff 10850.Dec 7 2015, 8:35 AM

Based on discussions in D4370 this is not compatible with the marvell,orion-ehci bindings. Can you either fix this, or mark the device in the device tree in such a way we could later fix the driver to use the upstream bindings. My preference is for the former as it makes it easier to use the same dts as Linux.

andrew requested changes to this revision.Dec 8 2015, 12:35 AM

andrew added a reviewer: andrew.

This revision now requires changes to proceed.Dec 8 2015, 12:35 AM

Added conditions for "marvell,orion-ehci" case, in which driver shouldn't attach interrupt line for errors.

andrew, I updated the diff. Please let me know if this is solution you expected.

Is D4370 needed with this version?

No. I just don't know how to mark it outdated on Phabricator.

bsz_semihalf.com mentioned this in D4375: Enable USB in kernconf of Armada38x.Dec 10 2015, 9:44 AM

In D4369#94435, @bsz_semihalf.com wrote:

No. I just don't know how to mark it outdated on Phabricator.

There is an option to abandon a change in the Action drop down menu.

andrew accepted this revision.Dec 10 2015, 9:48 AM

andrew edited edge metadata.

This revision is now accepted and ready to land.Dec 10 2015, 9:48 AM

Sure, thank you :)

bsz_semihalf.com added a child revision: D4371: Correct ifdefs in arm/mv/timer.c.Dec 11 2015, 12:49 PM

@ian, @imp, would you mind to review this and following commits? Or can we commit with approval of only one of reviewers?

In D4369#102633, @bsz_semihalf.com wrote:

@ian, @imp, would you mind to review this and following commits? Or can we commit with approval of only one of reviewers?

I've always considered any one reviewer approval good enough (although I try to wait long enough to let other reviews add comments if they want).

Closed by commit rS294427: Improve attachment of the ehci_mv driver (authored by zbb). · Explain WhyJan 20 2016, 1:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

usb/

controller/

ehci_mv.c

8 lines

Diff 10727

View Options

sys/dev/usb/controller/ehci_mv.c

Enhance attachment of ehci_mv driverClosedPublicActions