Page MenuHomeFreeBSD
Differential D34769

linuxkpi: Move class_create to .c file
ClosedPublic
Actions

Authored by imp on Apr 4 2022, 5:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 5, 8:32 PM
Unknown Object (File)
Sat, Sep 5, 12:06 PM
Unknown Object (File)
Sat, Sep 5, 10:29 AM
Unknown Object (File)
Fri, Sep 4, 1:05 PM
Unknown Object (File)
Thu, Sep 3, 8:21 PM
Unknown Object (File)
Wed, Sep 2, 12:39 PM
Unknown Object (File)
Tue, Sep 1, 4:28 AM
Unknown Object (File)
Tue, Sep 1, 3:15 AM
View All Files
Subscribers
bz
emaste
• hselasky
linuxkpi

Details

Reviewers
• hselasky
emaste
Commits
rG169aa349594c: linuxkpi: Move class_create to .c file
rG98d2b4a158f1: linuxkpi: Move class_create to .c file
rG1341ac9f9c11: linuxkpi: Move class_create to .c file
Summary

class_create encodes the size of struct class into the generated
code. Move from .h file to .c file to move this knowledge from the
client modules that call this into the linuxkpi module.

Sponsored by: Netflix

Test Plan

(adding bz to this one, there's a whole series and phab makes it hard to add people to multiple reviews)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44987
Build 41875: arc lint + arc unit

Event Timeline

imp created this revision.Apr 4 2022, 5:03 PM
Herald added subscribers: linuxkpi, emaste. · View Herald TranscriptApr 4 2022, 5:03 PM
imp requested review of this revision.Apr 4 2022, 5:03 PM
Harbormaster completed remote builds in B44987: Diff 104567.Apr 4 2022, 5:03 PM
imp added a parent revision: D34768: linuxkpi: Move device_create_groups_vargs to linux_compat.c.Apr 4 2022, 5:03 PM
imp added a child revision: D34770: linuxkpi: Remove write only variable from lkpi_iicbb_reset.
• hselasky accepted this revision.Apr 4 2022, 5:15 PM
• hselasky added a subscriber: • hselasky.

Make sure LINT passes, and that there are no conflicts with existing global symbols.

This revision is now accepted and ready to land.Apr 4 2022, 5:16 PM
emaste accepted this revision.Apr 4 2022, 5:17 PM
emaste added inline comments.
sys/compat/linuxkpi/common/src/linux_compat.c
505

how do Linux and FreeBSD flags interact?

• hselasky added inline comments.Apr 4 2022, 5:26 PM
sys/compat/linuxkpi/common/src/linux_compat.c
505

Yes. Can be changed to GFP_KERNEL .

imp added inline comments.Apr 4 2022, 8:10 PM
sys/compat/linuxkpi/common/src/linux_compat.c
505

I'm nervous about making any changes here... At least with the pure move it commits...
I'll do a grep for kzalloc to see what else is doing naughty things.

emaste added inline comments.Apr 4 2022, 8:14 PM
sys/compat/linuxkpi/common/src/linux_compat.c
505

OK, in any case I think there's value in doing these change separately from any style or functional cleanup

imp edited the test plan for this revision. (Show Details)Apr 4 2022, 8:16 PM
imp added a subscriber: bz.
Closed by commit rG1341ac9f9c11: linuxkpi: Move class_create to .c file (authored by imp). · Explain WhyApr 5 2022, 5:10 AM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG1341ac9f9c11: linuxkpi: Move class_create to .c file.
imp added a commit: rG98d2b4a158f1: linuxkpi: Move class_create to .c file.Apr 5 2022, 2:43 PM
imp added a commit: rG169aa349594c: linuxkpi: Move class_create to .c file.Apr 6 2022, 5:46 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
21 lines
src/
19 lines

Diff 104567

View Options

sys/compat/linuxkpi/common/include/linux/device.h

Loading...
View Options

sys/compat/linuxkpi/common/src/linux_compat.c

Loading...