Odd indentation, it should be options<space><tab>FOO

Is the port not able to use local storage?

Why do you need this?

Why are these needed?

Why have these if they are commented out?

Why have these?

More commented out options?

Can you not load the dtb from disk?

This should be #if defined(EARLY_PRINTF).

This should come from sys/conf/files.arm

Use options gic

Do you need this? i.e. do you need the trampoline kernel?

This should be unneeded

On a side note, this should be something like:

#error Unsupported SoC

Not yet. Storage devices will be added in next chunk of support for this SoC. Currently the only supported root device is md.

Some of these commented devices will be uncommented after we submit further commits. However, I can remove these for now, if you wish.

Is there a point to do this? We always need GIC (it's primary interrupt controller here - I don't think somebody would want not to use it), and including gic.c in standard doesn't interfere with other platforms (as this is files.armada38x).

SOCDEV_PA, _VA are required for EARLY_PRINTF. We use EARLY_PRINTF for debugging reasons.

As for now we are not using loader, so static dtb is required.

If you are still debugging the early boot why are you submitting the code? This should only be needed when things don't work.

Because sys/arm/foo/files.foo should only be used for files within sys/arm/foo. I've recently cleaned up most of the placed we pull in files in sys/arm/arm/* and moved them to files.arm.

Also, there is no reason to set KERNVIRTADDR to anything other than 0xc0000000 these days. The only reason we used to set any low-order bits was to influence where loader(8) loaded the image or to match where u-boot loaded the image. Now those bits have no influence and the kernel can be loaded on any 2MB boundary.

Why do you need NO_FFS_SNAPSHOT and NO_SWAPPING?

This should be device mpcore_timer in your config.

Why is this here?

I tried to set it to 0xc0000000 - doesn't boot (doesn't event print anything).

That sounds like a serious bug that needs to be investigated then. In theory, any kernvirtaddr at all should work for armv6 now, and I know for sure c0000000 works on imx6, and beaglebone. It now also works on dreamplug/kirkwood as of a couple days ago, so there's nothing in the mv-specific common code to prevent it.

Disregard my previous comment. It was matter of -DNO_CLEAN - after complete rebuild that works fine. I'll correct the commit.