Fix the spelling of EFI_PAGE_SIZE
ClosedPublic
Actions

Authored by andrew on Mar 9 2022, 6:42 PM.

Details

Reviewers

kib
markj
manu
imp

Group Reviewers

ARM
arm64

Commits

rG4366c226436b: Fix the spelling of EFI_PAGE_SIZE
rG9cf15aefb9d6: Fix the spelling of EFI_PAGE_SIZE

Summary

We assume EFI_PAGE_SIZE is the same as PAGE_SIZE, however this may not
be the case. Use the former when working with a list of pages from the
UEFI firmware so the correct size is used.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 44725
Build 41613: arc lint + arc unit

Event Timeline

andrew created this revision.Mar 9 2022, 6:42 PM

Herald added a reviewer: manu. · View Herald TranscriptMar 9 2022, 6:42 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

andrew requested review of this revision.Mar 9 2022, 6:42 PM

Harbormaster completed remote builds in B44725: Diff 103688.Mar 9 2022, 6:42 PM

These look good... but where's EFI_PAGE_SIZE defined? And does it need to be a run-time thing?
It's a good fix, but I'd like to understand the larger context :)

This revision is now accepted and ready to land.Mar 9 2022, 7:20 PM

In D34510#781812, @imp wrote:

These look good... but where's EFI_PAGE_SIZE defined? And does it need to be a run-time thing?
It's a good fix, but I'd like to understand the larger context :)

AFAIK the spec doesn't allow any flexibility here, every arch is forced to 4k pages to be compliant (see various mmu configuration verbiages in "Calling Conventions")

In D34510#781816, @kevans wrote:

In D34510#781812, @imp wrote:

These look good... but where's EFI_PAGE_SIZE defined? And does it need to be a run-time thing?
It's a good fix, but I'd like to understand the larger context :)

AFAIK the spec doesn't allow any flexibility here, every arch is forced to 4k pages to be compliant (see various mmu configuration verbiages in "Calling Conventions")