Page MenuHomeFreeBSD

Tidying up all the conditionals, when a spurious RTO is unwound
ClosedPublic

Authored by rscheff on Jan 27 2022, 3:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jun 16 2026, 12:48 PM
Unknown Object (File)
Jun 15 2026, 12:39 PM
Unknown Object (File)
Jun 7 2026, 10:10 AM
Unknown Object (File)
Jun 2 2026, 6:28 PM
Unknown Object (File)
May 21 2026, 6:28 AM
Unknown Object (File)
May 20 2026, 3:26 PM
Unknown Object (File)
May 20 2026, 12:51 AM
Unknown Object (File)
May 17 2026, 6:20 AM

Details

Summary

This is a split-off from D33979, where only an acute issue is addressed.

The below points were noted incidentially while addressing that TF_PREVVALID
must not, just by itself, be used as sole condition for restoring old TCP state.

  • Use the semantically correct TSTMP_xx macro when comparing timestamps. (No functional change)
  • check for bad retransmits only when TSopt is present in ACK (don't assume there will be a valid TSopt in the TCP options struct)
  • exclude tsecr == 0, since that most likely indicates an invalid ts echo return (tsecr) value.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44123
Build 41011: arc lint + arc unit