Differential D33544
Add a new libiscsiutil library. Authored by jhb on Dec 17 2021, 8:58 PM. Tags None Referenced Files
Details Move some of the code duplicated between ctld(8) and iscsid(8) into a Sharing the low-level PDU code did require having a Sponsored by: Chelsio Communications
Diff Detail
Event TimelineComment Actions (I ended up not going back and rewriting parts of this to use C++) Note that there is a net/libiscsi in ports, so perhaps this should use a different name, but I'm not sure what name to use in that case? Comment Actions I've looked quite briefly, but it looks pretty mechanical change due to complete duplication. I agree that libiscsi name is too obvious. I am actually using SCSI test suite out of github.com/sahlberg/libiscsi sometimes. Not sure what is better though, thinking about: iscsiutil, utiliscsi, kiscsi, ... Comment Actions Heh, that’s why I didn’t make it a library in the first place I think; naming is hard :-) FWIW, I really like the libiscsiutil name, I feel it really well describes what it really is. Comment Actions libiscsiutil works for me. We could also perhaps make it a private or internal lib (no public .so in /usr/lib) so that only ctld and iscsid would use it. Tagging @emaste so he can render an opinion on if that makes sense (and if so, which one it should be) Comment Actions I think it would be fine if there is a nice way to do it. I don't really expect it to be reused by anything else, since it is quite specialized and pretty small. Comment Actions
There is, just setting PRIVATELIB= in the Makefile will install it with a libprivate prefix, or INTERNALLIB= to create a .a to link against at build time, but not install it. As to which to choose it comes down to the usual arguments between dynamic and static linking. If the library is large and used by multiple consumers PRIVATELIB seems the way to go. For this case I'd think INTERNALLIB.
| ||||||||||||||||||||||||||||||||||||||||||||||||||