Page MenuHomeFreeBSD
Differential D33547

libiscsiutil: Change keys_load/save to operate on data buffers.
ClosedPublic
Actions

Authored by jhb on Dec 17 2021, 8:58 PM.
Tags
None
Referenced Files
F149104566: D33547.id.diff
Sun, Mar 22, 7:45 AM
Unknown Object (File)
Thu, Mar 19, 5:48 PM
Unknown Object (File)
Wed, Mar 18, 5:09 AM
Unknown Object (File)
Tue, Mar 17, 11:52 PM
Unknown Object (File)
Tue, Mar 17, 8:31 PM
Unknown Object (File)
Wed, Mar 11, 12:28 PM
Unknown Object (File)
Wed, Mar 11, 1:29 AM
Unknown Object (File)
Sun, Mar 8, 11:00 AM
View All Files
Subscribers
imp

Details

Reviewers
emaste
mav
trasz
Commits
rG54262b09e5ba: libiscsiutil: Change keys_load/save to operate on data buffers.
rG25700db36640: libiscsiutil: Change keys_load/save to operate on data buffers.
Summary

This will be used in future changes to support large text requests
spanning multiple PDUs.

Provide wrapper functions keys_load/save_pdu that operate use a PDU's
data buffer.

Sponsored by: Chelsio Communications

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Dec 17 2021, 8:58 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 17 2021, 8:58 PM
jhb requested review of this revision.Dec 17 2021, 8:58 PM
Harbormaster completed remote builds in B43454: Diff 100238.Dec 17 2021, 8:58 PM
jhb added a parent revision: D33546: libiscsiutil: Use open_memstream to build the outgoing block of keys..Dec 17 2021, 8:58 PM
jhb added a child revision: D33548: iscsi: Handle large Text responses..
mav accepted this revision.Dec 18 2021, 11:25 PM
This revision is now accepted and ready to land.Dec 18 2021, 11:25 PM
jhb retitled this revision from libiscsi: Change keys_load/save to operate on data buffers. to libiscsiutil: Change keys_load/save to operate on data buffers..Dec 21 2021, 12:29 AM
jhb updated this revision to Diff 100384.Dec 21 2021, 12:54 AM
  • Rebase after library rename.
This revision now requires review to proceed.Dec 21 2021, 12:54 AM
Harbormaster completed remote builds in B43517: Diff 100384.Dec 21 2021, 12:54 AM
This revision was not accepted when it landed; it landed in state Needs Review.Dec 22 2021, 6:44 PM
Closed by commit rG25700db36640: libiscsiutil: Change keys_load/save to operate on data buffers. (authored by jhb). · Explain Why
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG25700db36640: libiscsiutil: Change keys_load/save to operate on data buffers..
jhb added a commit: rG54262b09e5ba: libiscsiutil: Change keys_load/save to operate on data buffers..Apr 29 2022, 11:12 PM

Revision Contents
Changeset List

PathSize
lib/
libiscsiutil/
20 lines
18 lines
usr.sbin/
ctld/
4 lines
20 lines
iscsid/
4 lines
18 lines

Diff 100474

View Options

lib/libiscsiutil/keys.c

Loading...
View Options

lib/libiscsiutil/libiscsiutil.h

Loading...
View Options

usr.sbin/ctld/discovery.c

Loading...
View Options

usr.sbin/ctld/login.c

Loading...
View Options

usr.sbin/iscsid/discovery.c

Loading...
View Options

usr.sbin/iscsid/login.c

Loading...