Details

Reviewers

Commits

rS300015: [bhnd] Finish bhnd(4) PCI/PCIe-G1 hostb support.

Summary

Now that we've got access to SPROM and can access board identification, this diff
implements all known remaining hardware work-arounds for the bhnd(4) PCI
and PCIe-G1 cores operating endpoint mode.

Additionally, this adds an initial set of skeleton PCIe-G2 hostb and pcib drivers,
required by fullmac and newer softmac devices.

Depends on D6361

Test Plan

Verify that if_bwn_pci and bhnd_pci_hostb both still successfully attach on
siba(4) and bcma(4) devices.

Tested against BCM4331 (bcma) and BCM4312 (siba).

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3754
Build 3797: arc lint + arc unit

Event Timeline

landon_landonf.org updated this revision to Diff 16351.May 15 2016, 6:38 PM

landon_landonf.org retitled this revision from to Finish bhnd(4) PCI/PCIe-G1 hostb support.

landon_landonf.org updated this object.

landon_landonf.org edited the test plan for this revision. (Show Details)

landon_landonf.org added a reviewer: adrian.

landon_landonf.org added a parent revision: D6361: [BHND] Centralize fetching of board information.

Herald added a subscriber: imp. · View Herald TranscriptMay 15 2016, 6:38 PM

Fix spelling in comment.

This doesn't patch clean against the latest -HEAD. Would you mind updating?

Rebased against HEAD.

Manually generated patch with git rename tracking disabled, applies cleanly against SVN.

Closed by commit rS300015: [bhnd] Finish bhnd(4) PCI/PCIe-G1 hostb support. (authored by adrian). · Explain WhyMay 17 2016, 6:53 AM

This revision was automatically updated to reflect the committed changes.

Commit	Tree	Parents	Author	Summary	Date
4932355bc2a4	9fbd5260cc58	8fbfdf58f43a 802c5ec041e0	Landon Fuller	Merge branch 'user/landonf/bhnd/001_get_boardinfo' into… (Show More…)	May 15 2016, 6:16 PM
8fbfdf58f43a	9ca1f65211ef	bc2bea8bebd8	Landon Fuller	Implement siba initiator timeout workaround for BCM4311 and BCM4312 devices.	May 15 2016, 5:55 PM
bc2bea8bebd8	1f6a7f6666b7	c1927e04300f	Landon Fuller	Revert "Add 1/2/4-byte bhnd_nvram_getvar_* convenience functions." (Show More…)	May 15 2016, 7:20 AM
c1927e04300f	2c90e699e816	791f7406bf80	Landon Fuller	Remove extra line escape.	May 15 2016, 7:17 AM
791f7406bf80	41c197e1625a	66b868d874a9	Landon Fuller	Implement MRRS quirk handling.	May 15 2016, 5:55 AM
66b868d874a9	dd29a89a5b22	5df55e3bb4e0	Landon Fuller	Add quirk flags for PCIe MRRS 128/512 handling.	May 15 2016, 5:37 AM
5df55e3bb4e0	e5ad304ea043	e3227ad2efe0	Landon Fuller	Move BHND_PCIE2_QUIRK_SERDES_TXDRV_DEEMPH to the bhnd_pcie2_hostb driver; the… (Show More…)	May 15 2016, 2:22 AM
e3227ad2efe0	676d1ec01ac8	9a990fe0e5c8	Landon Fuller	Implement Apple BCM4331/BCM4322 TX drive strength workarounds.	May 15 2016, 1:55 AM
9a990fe0e5c8	fcb628546aa8	51c8775dbf54	Landon Fuller	Add quirk flags for the TX drive strength issues, and document all remaining… (Show More…)	May 14 2016, 8:38 PM
51c8775dbf54	e3ac551ea0ff	22d1ca6f2d46	Landon Fuller	Add a quirk flag for the 960ns PCI latency timer workaround required on some… (Show More…)	May 14 2016, 7:42 PM
22d1ca6f2d46	fd65b051c8c0	c7e0df62ac57	Landon Fuller	Define a quirk flag for the Apple 4360 PCIe SerDes Tx amplitude/deemphasis work… (Show More…)	May 14 2016, 7:18 PM
c7e0df62ac57	2ed2cdf9b467	7ad3f32914df	Landon Fuller	Add workaround for board_type handling on Apple PCIe BCM4360 modules	May 14 2016, 7:17 PM
7ad3f32914df	8a68b80ae9a6	a6ba19d489ad	Landon Fuller	Drop redundant PCIe capability register defines.	May 14 2016, 4:11 PM
a6ba19d489ad	1e6b83a47d51	7d781761f12f	Landon Fuller	Drop WOWL and MDIO power TODOs; both are non-quirk behaviors that can be added… (Show More…)	May 14 2016, 4:10 PM
7d781761f12f	a73e6f753a57	95585ade731b	Landon Fuller	Implement work-around for BHND_PCIE_QUIRK_SERDES_NOPLLDOWN.	May 14 2016, 6:29 AM
95585ade731b	aa9bbf07aa9a	2744202fb002	Landon Fuller	Use pcie_(read\|write)_config to read/write PCIER_LINK_CTL instead of applying… (Show More…)	May 14 2016, 5:40 AM
2744202fb002	11ec446b22ff	405e0992ac09	Landon Fuller	Combine the bhnd_pci* and bhnd_pcie2* loadable modules.	May 14 2016, 5:14 AM
405e0992ac09	dc0253e66114	b81e0e3ffd4a	Landon Fuller	Add a skeleton driver for the PCIe-G2 core.	May 14 2016, 5:11 AM
b81e0e3ffd4a	d5fa56598f26	f8bd2a14bf6a	Landon Fuller	Implement BHND_PCIE_QUIRK_ASPM_OVR (ASPM/ECPM override) quirk workaround.	May 14 2016, 12:52 AM
f8bd2a14bf6a	016ee1fbbf29	fbf251580006 91f2081ed884	Landon Fuller	Merge branch 'user/landonf/bhnd/001_get_boardinfo' into… (Show More…)	May 13 2016, 11:47 PM
fbf251580006	534951bb1bbc	b59ba4031cd4	Landon Fuller	Add missing BHND_CHIP_QUIRK_END table terminator.	May 13 2016, 11:08 PM
b59ba4031cd4	6fe946eb7d7f	7b7fc7db578b	Landon Fuller	Use the new board quirk matching support to handle… (Show More…)	May 13 2016, 8:48 PM
7b7fc7db578b	600118f5d0c0	b0de7f3e46fd f397ff28f03a	Landon Fuller	Merge branch 'user/landonf/bhnd/001_get_boardinfo' into… (Show More…)	May 13 2016, 8:31 PM
b0de7f3e46fd	771532cd9be9	07e8629f97b9	Landon Fuller	Add Apple-specific BHND_PCIE_QUIRK_ASPM_OVR quirk handling.	May 9 2016, 11:53 PM
07e8629f97b9	d1c2554fbf77	4e3a135864d8 ed7b29966204	Landon Fuller	Merge branch 'master' into user/landonf/bhnd/01_pci_hostb_bringup	May 9 2016, 11:24 PM
4e3a135864d8	cdedcc63d080	75c9edfb4644	Landon Fuller	Clarify the relationship between bhndb_pci and bhnd_pci_hostb drivers.	May 9 2016, 12:27 AM
75c9edfb4644	f042995b725f	b14fbc1f0d3a	Landon Fuller	Clarify BHND_PCIE_QUIRK_ASPM_OVR description.	May 9 2016, 12:07 AM
b14fbc1f0d3a	18f4e698a84a	d6e0fd655479	Landon Fuller	Use the new NVRAM APIs to fetch the ASPM/CLKREQ WAR override setting.	May 7 2016, 10:59 PM
d6e0fd655479	284acfac864f	911b343fdd8f	Landon Fuller	Add 1/2/4-byte bhnd_nvram_getvar_* convenience functions.	May 7 2016, 10:58 PM
911b343fdd8f	abd804ae95b3	554ab3159252	Landon Fuller	Add support for walking the device tree to locate the bhnd bridge's root device. (Show More…)	May 7 2016, 10:30 PM
554ab3159252	5d8f9549cdd7	ef24e4e75848	Landon Fuller	Bring up ChipCommon prior to the host bridge driver (which requires access to… (Show More…)	May 7 2016, 9:45 PM
ef24e4e75848	a40db6c94045	6ae1c286e45b	Landon Fuller	Revisit and clean up clock handling TODOs.	May 7 2016, 9:08 PM
6ae1c286e45b	e8e0bb59ebd8	52e4181a86ed	Landon Fuller	Add a variable definition for the sromrev.	May 7 2016, 8:33 PM
52e4181a86ed	af7334716924	2b5351201024	Landon Fuller	Re-integrate module dependency that went missing in a merge.	May 7 2016, 7:22 PM
2b5351201024	44b7cfdb79f0	649d0d2114da	Landon Fuller	Add an explicit fallback cases for unmatched enums. (Show More…)	May 7 2016, 7:10 PM
649d0d2114da	f7554fb65679	21569015897d	Landon Fuller	Rename the bhnd_nvram_* variable functions (modeled on the OF_prop* API).	May 7 2016, 6:46 PM
21569015897d	06ef936c09ca	02fdfc634041	Landon Fuller	Allow ChipCommon to attach when OTP or NFLASH SPROM sources are identified. (Show More…)	May 7 2016, 6:39 PM
02fdfc634041	6f59d227431b	5aacf6a00cb7	Landon Fuller	Truncate the output file prior to appending the variable tables.	May 7 2016, 6:32 PM
5aacf6a00cb7	be52db1f04b2	bda99e02ae34 fb5379ba07b5	Landon Fuller	Merge branch 'user/landonf/bhnd/chipset_quirk_matching' into… (Show More…)	May 7 2016, 4:27 PM
fb5379ba07b5	94104ad4817b	06ee4796fc3b 4fced9480acc	Landon Fuller	Merge branch 'user/landonf/bhnd/bhnd_res_stream' into… (Show More…)	May 7 2016, 4:21 PM
4fced9480acc	1c80bd32f8fd	2e49ab35fe84 33af682595d3	Landon Fuller	Merge branch 'user/landonf/bhnd/is_hostb_device' into… (Show More…)	May 7 2016, 4:16 PM
33af682595d3	8238577e3b19	50c7e65e30f0 f73a7179da33	Landon Fuller	Merge branch 'master' into user/landonf/bhnd/is_hostb_device	May 7 2016, 4:05 PM
bda99e02ae34	be52db1f04b2	1b0dbdcb03e0 06ee4796fc3b	Landon Fuller	Merge branch 'user/landonf/bhnd/chipset_quirk_matching' into… (Show More…)	May 7 2016, 3:59 PM
06ee4796fc3b	94104ad4817b	10600c446917 2e49ab35fe84	Landon Fuller	Merge branch 'user/landonf/bhnd/bhnd_res_stream' into… (Show More…)	May 7 2016, 3:58 PM
2e49ab35fe84	1c80bd32f8fd	95a5a4880dd2	Landon Fuller	Integrate bus read/write method implementations. (Show More…)	May 7 2016, 3:54 PM
95a5a4880dd2	c3bb2f88b4a2	f05ff4f4f8f4 f73a7179da33	Landon Fuller	Merge branch 'master' into user/landonf/bhnd/bhnd_res_stream	May 7 2016, 3:51 PM
1b0dbdcb03e0	97ea77328f53	dbb7e041ccbe 10600c446917	Landon Fuller	Merge branch 'user/landonf/bhnd/chipset_quirk_matching' into… (Show More…)	May 7 2016, 2:55 PM
dbb7e041ccbe	4a3a49bdbbdd	329d36cc971e	Landon Fuller	Add support for generating a set of #defines for all bhnd(4) NVRAM variable… (Show More…)	May 7 2016, 3:13 AM
10600c446917	e8ba218b1b39	b8dc34ef805c	Landon Fuller	Remove duplicate prototype introduced in earlier merge.	May 7 2016, 1:56 AM
329d36cc971e	2dfd387f0391	50bc79ebd991 f73a7179da33	Landon Fuller	Merge branch 'master' into user/landonf/bhnd/initial_sprom_support	May 6 2016, 10:53 PM
50bc79ebd991	d2d3e219b134	e8ae245ca956 b8dc34ef805c	Landon Fuller	Merge branch 'user/landonf/bhnd/chipset_quirk_matching' into… (Show More…)	May 6 2016, 12:23 AM
e8ae245ca956	d2d3e219b134	112092a638e0	Landon Fuller	Use the variable table order guarantee to implement binary search for variable… (Show More…)	May 5 2016, 3:06 AM
112092a638e0	b23a62d59ca8	bc1900f02f94	Landon Fuller	Explicitly set LC_ALL=C to guarantee a stable sort order.	May 5 2016, 2:54 AM
bc1900f02f94	249c99a5e374	654cce4d006c	Landon Fuller	Remove debugging statement	May 5 2016, 2:54 AM
654cce4d006c	dffef5bd2c10	5e52583ee5d4	Landon Fuller	Implement a stable sorting guarantee for the generated NVRAM table.	May 5 2016, 2:39 AM
5e52583ee5d4	11346cc7593a	8887c5974076	Landon Fuller	Construct real variable records for all struct-defined variables. (Show More…)	May 5 2016, 1:28 AM
8887c5974076	5264b95dabb2	9bb48786d83d cd441cb61188	Landon Fuller	Merge branch 'master' into user/landonf/bhnd/initial_sprom_support	May 5 2016, 11:34 PM
f05ff4f4f8f4	651eeeb71f71	5cea937df978 cd441cb61188	Landon Fuller	Merge branch 'master' into user/landonf/bhnd/bhnd_res_stream	May 5 2016, 11:26 PM
50c7e65e30f0	1af96e07ca1c	eb152c21108b cd441cb61188	Landon Fuller	Merge branch 'master' into user/landonf/bhnd/is_hostb_device	May 5 2016, 11:25 PM
b8dc34ef805c	1ab26eab5f4d	8f2af5d71307 cd441cb61188	Landon Fuller	Merge branch 'master' into user/landonf/bhnd/chipset_quirk_matching	May 5 2016, 11:25 PM
9bb48786d83d	0a9e5dc93631	38be251cc70e	Landon Fuller	Minor spelling fix.	May 3 2016, 7:19 PM
38be251cc70e	c8c06a6f7a48	8f2af5d71307	Landon Fuller	Initial bhnd(4) SPROM/NVRAM support. (Show More…)	May 3 2016, 7:12 PM
8f2af5d71307	81b244975818	5cea937df978	Landon Fuller	Add support for matching on chip identifiers. (Show More…)	May 3 2016, 7:07 PM
5cea937df978	cfb33941b973	eb152c21108b	Landon Fuller	Add bhnd_resource support for the bus_(read\|write)(_multi_)stream_* functions. (Show More…)	May 3 2016, 6:58 PM
eb152c21108b	06bd77764be5	b3c5e346a55a	Landon Fuller	Replace is_hostb_device() with a more general find_hostb_device(). (Show More…)	May 3 2016, 6:49 PM
b3c5e346a55a	758f1d8a7d82	c6bedc6f35e2	Landon Fuller	Fix merge issue in match table.	May 3 2016, 6:31 PM
c6bedc6f35e2	2d3e5291f830	ae60941947f8	Landon Fuller	Minor spelling fix	May 3 2016, 6:03 PM
ae60941947f8	68690f6e65cd	2f257d03701d	Landon Fuller	Integrate the new bhnd-based if_bwn_pci driver. (Show More…)	May 3 2016, 5:48 PM

Finish bhnd(4) PCI/PCIe-G1 hostb support
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 16351

sys/conf/files

sys/dev/bhnd/bhnd.h

sys/dev/bhnd/bhnd_ids.h

sys/dev/bhnd/bhnd_subr.c

sys/dev/bhnd/bhndb/bhndb_pci.c

sys/dev/bhnd/bhndb/bhndb_pcireg.h

sys/dev/bhnd/cores/chipc/bhnd_chipc_if.m

sys/dev/bhnd/cores/chipc/chipc.c

sys/dev/bhnd/cores/pci/bhnd_pci.c

sys/dev/bhnd/cores/pci/bhnd_pci_hostb.c

sys/dev/bhnd/cores/pci/bhnd_pci_hostbvar.h

sys/dev/bhnd/cores/pci/bhnd_pcib.c

sys/dev/bhnd/cores/pci/bhnd_pcireg.h

sys/dev/bhnd/cores/pcie2/bhnd_pcie2.c

sys/dev/bhnd/cores/pcie2/bhnd_pcie2_hostb.c

sys/dev/bhnd/cores/pcie2/bhnd_pcie2_hostbvar.h

sys/dev/bhnd/cores/pcie2/bhnd_pcie2_reg.h

sys/dev/bhnd/cores/pcie2/bhnd_pcie2_var.h

sys/dev/bhnd/cores/pcie2/bhnd_pcie2b.c

sys/dev/bhnd/cores/pcie2/bhnd_pcie2b_var.h

sys/dev/bhnd/siba/siba.c

sys/dev/bhnd/siba/siba_bhndb.c

sys/dev/bhnd/siba/sibavar.h

sys/modules/bhnd/cores/bhnd_pci/Makefile

sys/modules/bhnd/cores/bhnd_pci_hostb/Makefile

sys/modules/bhnd/cores/bhnd_pcib/Makefile

Finish bhnd(4) PCI/PCIe-G1 hostb supportClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 16351

sys/conf/files

sys/dev/bhnd/bhnd.h

sys/dev/bhnd/bhnd_ids.h

sys/dev/bhnd/bhnd_subr.c

sys/dev/bhnd/bhndb/bhndb_pci.c

sys/dev/bhnd/bhndb/bhndb_pcireg.h

sys/dev/bhnd/cores/chipc/bhnd_chipc_if.m

sys/dev/bhnd/cores/chipc/chipc.c

sys/dev/bhnd/cores/pci/bhnd_pci.c

sys/dev/bhnd/cores/pci/bhnd_pci_hostb.c

sys/dev/bhnd/cores/pci/bhnd_pci_hostbvar.h

sys/dev/bhnd/cores/pci/bhnd_pcib.c

sys/dev/bhnd/cores/pci/bhnd_pcireg.h

sys/dev/bhnd/cores/pcie2/bhnd_pcie2.c

sys/dev/bhnd/cores/pcie2/bhnd_pcie2_hostb.c

sys/dev/bhnd/cores/pcie2/bhnd_pcie2_hostbvar.h

sys/dev/bhnd/cores/pcie2/bhnd_pcie2_reg.h

sys/dev/bhnd/cores/pcie2/bhnd_pcie2_var.h

sys/dev/bhnd/cores/pcie2/bhnd_pcie2b.c

sys/dev/bhnd/cores/pcie2/bhnd_pcie2b_var.h

sys/dev/bhnd/siba/siba.c

sys/dev/bhnd/siba/siba_bhndb.c

sys/dev/bhnd/siba/sibavar.h

sys/modules/bhnd/cores/bhnd_pci/Makefile

sys/modules/bhnd/cores/bhnd_pci_hostb/Makefile

sys/modules/bhnd/cores/bhnd_pcib/Makefile

Finish bhnd(4) PCI/PCIe-G1 hostb support
ClosedPublic
Actions

Revision Contents
Changeset List