[BHND] Add support for matching of MIPS & ARM cores
ClosedPublic
Actions

Authored by mizhka on May 6 2016, 5:21 PM.

Details

Reviewers

landon_landonf.org
adrian

Commits

rS299989: [bhnd] Add support for matching of MIPS & ARM cores

Summary

Extend macros for MIPS & ARM cores. Now only BCM cores can be matched by matching mechanism.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mizhka updated this revision to Diff 15981.May 6 2016, 5:21 PM

mizhka retitled this revision from to [BHND] Add support for matching of MIPS & ARM cores.

mizhka updated this object.

mizhka edited the test plan for this revision. (Show Details)

mizhka added reviewers: adrian, landon_landonf.org.

mizhka set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptMay 6 2016, 5:21 PM

Other than minor style(9) whitespace and prefixing the macro names, looks good.

sys/dev/bhnd/bhnd.h
264 ↗	(On Diff #15981)	minor style(9): should be a `\t` between `#define` and the macro name. Could you also prefix these with `BHND_`? Could be `BHND_MIPS_DEV` to keep them short.

This revision now requires changes to proceed.May 6 2016, 8:50 PM

Fix style(9) issue (tab after #define)
Macros names start with BHND_ now

mizhka marked an inline comment as done.May 7 2016, 10:24 PM

Looks good to me.

This revision is now accepted and ready to land.May 11 2016, 7:34 PM

landon_landonf.org added a child revision: D6361: [BHND] Centralize fetching of board information.May 13 2016, 11:45 PM

Closed by commit rS299989: [bhnd] Add support for matching of MIPS & ARM cores (authored by adrian). · Explain WhyMay 16 2016, 11:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

bhnd/

bhnd.h

12 lines

Diff 16421

View Options

[BHND] Add support for matching of MIPS & ARM coresClosedPublicActions