Page MenuHomeFreeBSD
Differential D6246

[BHND] Add support for matching of MIPS & ARM cores
ClosedPublic
Actions

Authored by mizhka on May 6 2016, 5:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 6, 12:24 PM
Unknown Object (File)
Mon, Apr 6, 10:50 AM
Unknown Object (File)
Mon, Apr 6, 1:39 AM
Unknown Object (File)
Sun, Apr 5, 9:48 AM
Unknown Object (File)
Sat, Apr 4, 11:42 PM
Unknown Object (File)
Fri, Apr 3, 4:39 AM
Unknown Object (File)
Thu, Apr 2, 6:19 AM
Unknown Object (File)
Wed, Apr 1, 6:38 PM
View All Files
Subscribers
imp

Details

Reviewers
landon_landonf.org
adrian
Commits
rS299989: [bhnd] Add support for matching of MIPS & ARM cores
Summary

Extend macros for MIPS & ARM cores. Now only BCM cores can be matched by matching mechanism.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mizhka updated this revision to Diff 15981.May 6 2016, 5:21 PM
mizhka retitled this revision from to [BHND] Add support for matching of MIPS & ARM cores.
mizhka updated this object.
mizhka edited the test plan for this revision. (Show Details)
mizhka added reviewers: adrian, landon_landonf.org.
mizhka set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptMay 6 2016, 5:21 PM
landon_landonf.org requested changes to this revision.May 6 2016, 8:50 PM
landon_landonf.org edited edge metadata.

Other than minor style(9) whitespace and prefixing the macro names, looks good.

sys/dev/bhnd/bhnd.h
264 ↗(On Diff #15981)

minor style(9): should be a \t between #define and the macro name.

Could you also prefix these with BHND_? Could be BHND_MIPS_DEV to keep them short.

This revision now requires changes to proceed.May 6 2016, 8:50 PM
mizhka updated this revision to Diff 16028.May 7 2016, 10:24 PM
mizhka edited edge metadata.
  • Fix style(9) issue (tab after #define)
  • Macros names start with BHND_ now
mizhka marked an inline comment as done.May 7 2016, 10:24 PM
landon_landonf.org accepted this revision.May 11 2016, 7:34 PM
landon_landonf.org edited edge metadata.

Looks good to me.

This revision is now accepted and ready to land.May 11 2016, 7:34 PM
landon_landonf.org added a child revision: D6361: [BHND] Centralize fetching of board information.May 13 2016, 11:45 PM
Closed by commit rS299989: [bhnd] Add support for matching of MIPS & ARM cores (authored by adrian). · Explain WhyMay 16 2016, 11:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
bhnd/
12 lines

Diff 16421

View Options

head/sys/dev/bhnd/bhnd.h

Loading...