Paths

Table of Contentst

Differential D60095

x86: Add Intel Last Branch Records MSRs
AcceptedPublic
Actions

Authored by des on Mon, Sep 28, 4:18 PM.

Tags

None

Referenced Files

	F173873837: D60095.id187894.diff
	Tue, Sep 29, 1:11 AM

	F173872405: D60095.diff
	Tue, Sep 29, 12:58 AM

	F173858088: D60095.id187894.diff
	Mon, Sep 28, 10:49 PM

	F173847085: D60095.diff
	Mon, Sep 28, 9:08 PM

Subscribers

Details

Reviewers

siderop1_netapp.com

Group Reviewers

Summary

Sponsored by: Klara, Inc.
Sponsored by: NetApp, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77416
Build 74299: arc lint + arc unit

Event Timeline

des created this revision.Mon, Sep 28, 4:18 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Sep 28, 4:18 PM

des requested review of this revision.Mon, Sep 28, 4:18 PM

Harbormaster completed remote builds in B77416: Diff 187894.Mon, Sep 28, 4:18 PM

des added inline comments.Mon, Sep 28, 4:28 PM

sys/x86/include/specialreg.h
680–681	These two are called `MSR_LER_FROM_LIP` and `MSR_LER_TO_LIP` in the Intel SDM, and their actual address varies from generation to generation. I wonder if we should remove them.
682–683	I can't find any reference to these in the Intel SDM. Some processor generations have `MSR_LER_FROM_LIP` and `MSR_LER_TO_LIP` at these addresses.

siderop1_netapp.com accepted this revision.Mon, Sep 28, 5:09 PM

This revision is now accepted and ready to land.Mon, Sep 28, 5:09 PM

siderop1_netapp.com added inline comments.Mon, Sep 28, 5:10 PM

sys/x86/include/specialreg.h
680–681	If they are variable, they should be removed IMO
682–683	I think these should be removed as well.

Revision Contents
Changeset List

Path

Size

sys/

x86/

include/

2 lines

Diff 187894

sys/x86/include/specialreg.h

Loading...