Page MenuHomeFreeBSD
Differential D59174

arm64: Fix the ICC_SGI1R_EL1 field names
ClosedPublic
Actions

Authored by andrew on Aug 25 2026, 2:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 9, 6:46 AM
Unknown Object (File)
Wed, Oct 7, 11:14 AM
Unknown Object (File)
Tue, Oct 6, 7:44 AM
Unknown Object (File)
Mon, Oct 5, 11:33 AM
Unknown Object (File)
Mon, Oct 5, 10:44 AM
Unknown Object (File)
Mon, Oct 5, 9:01 AM
Unknown Object (File)
Sun, Oct 4, 6:57 PM
Unknown Object (File)
Sun, Oct 4, 2:33 PM
View All 67 Files
Subscribers
emaste
imp
kajetan.puchalski_arm.com

Details

Reviewers
manu
kajetan.puchalski_arm.com
Group Reviewers
arm64
Commits
rGe1f684a16036: arm64: Fix the ICC_SGI1R_EL1 field names
Summary

Use the field names from the Arm Documentation for the ICC_SGI1R_EL1
register. These will later be generated from a BSD Licensed JSON file
so to reduce the diff for that rename now.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

andrew created this revision.Aug 25 2026, 2:36 PM
Herald added a reviewer: manu. · View Herald TranscriptAug 25 2026, 2:36 PM
Herald added subscribers: emaste, imp. · View Herald Transcript
andrew requested review of this revision.Aug 25 2026, 2:36 PM
Harbormaster completed remote builds in B76147: Diff 185028.Aug 25 2026, 2:36 PM
andrew added a parent revision: D59173: arm64: Fix the CTR_EL0 field names.Aug 25 2026, 2:36 PM
andrew added a child revision: D59175: arm64: Fix the ID_AA64MMFR1_EL1.CMOW name.
kajetan.puchalski_arm.com accepted this revision.Sep 8 2026, 2:24 PM
kajetan.puchalski_arm.com added a subscriber: kajetan.puchalski_arm.com.

Looks correct, with a small suggestion for a style fix. Probably not all that important if the plan is to remove those completely and have them be generated.

sys/arm64/include/armreg.h
837–850

We could capitalise the few non-capitalised "ul" suffixes for consistency & readability

This revision is now accepted and ready to land.Sep 8 2026, 2:24 PM
andrew added inline comments.Sep 9 2026, 2:16 PM
sys/arm64/include/armreg.h
837–850

I'll change them to use the UL(x) macro so they work in asm when generating these

Closed by commit rGe1f684a16036: arm64: Fix the ICC_SGI1R_EL1 field names (authored by andrew). · Explain WhySep 9 2026, 2:23 PM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rGe1f684a16036: arm64: Fix the ICC_SGI1R_EL1 field names.

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
8 lines
include/
38 lines
vmm/
io/
15 lines

Diff 186261

View Options

sys/arm64/arm64/gic_v3.c

Loading...
View Options

sys/arm64/include/armreg.h

Loading...
View Options

sys/arm64/vmm/io/vgic_v3.c

Loading...