Page MenuHomeFreeBSD

arm64: Fix the ICC_SGI1R_EL1 field names
ClosedPublic

Authored by andrew on Tue, Aug 25, 2:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 18, 1:10 PM
Unknown Object (File)
Wed, Sep 16, 7:50 AM
Unknown Object (File)
Wed, Sep 16, 5:16 AM
Unknown Object (File)
Wed, Sep 16, 3:23 AM
Unknown Object (File)
Mon, Sep 14, 1:38 PM
Unknown Object (File)
Mon, Sep 14, 11:38 AM
Unknown Object (File)
Mon, Sep 14, 1:11 AM
Unknown Object (File)
Sun, Sep 13, 4:57 PM

Details

Summary

Use the field names from the Arm Documentation for the ICC_SGI1R_EL1
register. These will later be generated from a BSD Licensed JSON file
so to reduce the diff for that rename now.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Looks correct, with a small suggestion for a style fix. Probably not all that important if the plan is to remove those completely and have them be generated.

sys/arm64/include/armreg.h
837–850

We could capitalise the few non-capitalised "ul" suffixes for consistency & readability

This revision is now accepted and ready to land.Tue, Sep 8, 2:24 PM
sys/arm64/include/armreg.h
837–850

I'll change them to use the UL(x) macro so they work in asm when generating these

This revision was automatically updated to reflect the committed changes.