Page MenuHomeFreeBSD

ptrace(PT_GET_ABI_NAME)
ClosedPublic

Authored by kib on Sat, Aug 22, 11:07 PM.
Tags
None
Referenced Files
F170915852: D59113.id184884.diff
Mon, Sep 7, 1:43 PM
Unknown Object (File)
Sun, Sep 6, 2:51 PM
Unknown Object (File)
Sun, Sep 6, 1:37 PM
Unknown Object (File)
Sun, Sep 6, 1:34 PM
Unknown Object (File)
Sun, Sep 6, 11:53 AM
Unknown Object (File)
Sun, Sep 6, 10:36 AM
Unknown Object (File)
Sun, Sep 6, 9:39 AM
Unknown Object (File)
Sun, Sep 6, 9:18 AM

Details

Summary

This covers the immediate need of truss(1), allowing to postpone pdkinfo(2).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib requested review of this revision.Sat, Aug 22, 11:07 PM

Use the right target process.

lib/libsys/ptrace.2
1111 ↗(On Diff #184762)

Or "defines how system call numbers and arguments are interpreted."

Or "the ABI selects the system call table used by the process."

1116 ↗(On Diff #184762)

IMO this makes it slightly more obvious that the nul-terminator is included.

sys/compat/freebsd32/freebsd32_misc.c
1257

udata <= strlen(...) is a signed/unsigned comparison, no? Don't we thus need an explicit check for udata < 0?

sys/kern/sys_process.c
889

Same comment about negative data.

2026

Shouldn't truncation result in an error?

kib marked 5 inline comments as done.

Fix signed/unsigned comparison.
Report error on too long ABI name.
Man page improvements.

This revision is now accepted and ready to land.Tue, Aug 25, 5:56 PM