LinuxKPI: fix argument type to lkpi_pci_msi_desc_alloc()
ClosedPublic
Actions

Authored by bz on Sun, Aug 16, 10:17 PM.

Details

Reviewers

dumbbell

Group Reviewers

linuxkpi

Commits

rGcfb23b01e269: LinuxKPI: fix argument type to lkpi_pci_msi_desc_alloc()

Summary

lkpi_pci_msi_desc_alloc() takes an unsigned int, not an int.
While here make sure the prototype is visibile in interrupt.h as
well before use to avoid -Wimplicit-function-declaration errors.

MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz created this revision.Sun, Aug 16, 10:17 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptSun, Aug 16, 10:17 PM

bz requested review of this revision.Sun, Aug 16, 10:17 PM

Harbormaster completed remote builds in B75635: Diff 184152.Sun, Aug 16, 10:17 PM

bz added a parent revision: D58878: LinuxKPI: pci: add pci_select_bars() and pci_msix_vec_count().Sun, Aug 16, 10:22 PM

bz added a child revision: D58880: LinuxKPI: implement dma_{alloc,free}_{noncoherent,attrs}.

emaste added a project: linuxkpi.Mon, Aug 17, 4:57 PM

dumbbell added a subscriber: dumbbell.Thu, Sep 10, 6:57 PM

dumbbell added inline comments.

sys/compat/linuxkpi/common/include/linux/pci.h
391	Isn’t this a duplicate declaration now that `<linux/interrupt.h>` is included?

bz added inline comments.Thu, Sep 10, 7:47 PM

sys/compat/linuxkpi/common/include/linux/pci.h
391	Yes it would be; but it belongs here. The function declaration in interrupt.h is needed in case something includes pci.h before interrupt.h now as pci.h includes interrupt.h and the function is not declared at that point yet as the "circular" include of pci.h in interrupt.h is prevented by the header guards. The question is why did I have to include interrupt.h here as well; that likely should be a different change? Let me go and find the error I encountered.

dumbbell added inline comments.Thu, Sep 10, 7:49 PM

sys/compat/linuxkpi/common/include/linux/pci.h
391	On Linux, `<linux/pci.h>` includes `<linux/interrupt.h>`, thus I believe this is right. Don’t you get a compiler warning because of this duplicate?

bz added inline comments.Thu, Sep 10, 7:59 PM

sys/compat/linuxkpi/common/include/linux/pci.h
391	No, why? For as long as the function declarations are matching you can have as many as you want. There's not duplicate public function with the same name here. I do not think we apply GCC's -Wredundant-decls anywhere; at least with clang that would not complain either.