Page MenuHomeFreeBSD
Differential D58246

Only build secure/libexec/ssh-sk-helper if MK_USB == no
ClosedPublic
Actions

Authored by ngie on Jul 15 2026, 12:39 AM.
Tags
None
Referenced Files
F170546465: D58246.id182014.diff
Sat, Sep 5, 8:32 AM
F170420818: D58246.id182476.diff
Fri, Sep 4, 6:20 PM
Unknown Object (File)
Fri, Sep 4, 9:51 AM
Unknown Object (File)
Fri, Sep 4, 1:43 AM
Unknown Object (File)
Thu, Sep 3, 11:37 PM
Unknown Object (File)
Thu, Sep 3, 4:46 PM
Unknown Object (File)
Wed, Sep 2, 9:42 AM
Unknown Object (File)
Tue, Sep 1, 11:12 PM
View All 65 Files
Subscribers
des
imp

Details

Reviewers
emaste
Commits
rG4db3872aabc3: Only build secure/libexec/ssh-sk-helper if MK_USB == no
Summary

The ssh-sk-helper utility only functions if/when MK_USB == yes.
Installing it on systems where MK_USB == no doesn't make sense.

Test Plan

This change unbreaks the build with a VM where MK_USB == no is set.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ngie created this revision.Jul 15 2026, 12:39 AM
Herald added a subscriber: imp. · View Herald TranscriptJul 15 2026, 12:39 AM
ngie requested review of this revision.Jul 15 2026, 12:39 AM
Harbormaster completed remote builds in B74819: Diff 182014.Jul 15 2026, 12:39 AM
ngie updated this revision to Diff 182015.Jul 15 2026, 12:46 AM
  • Remove redundant SRCS entry added in original diff.
  • Add MK_USB == no entries to OptionalObsoleteFiles.inc .
Harbormaster completed remote builds in B74820: Diff 182015.Jul 15 2026, 12:46 AM
ngie edited the summary of this revision. (Show Details)Jul 15 2026, 12:47 AM
ngie edited the test plan for this revision. (Show Details)
ngie added a reviewer: emaste.
ngie added a subscriber: des.
This revision was not accepted when it landed; it landed in state Needs Review.Jul 22 2026, 7:34 PM
Closed by commit rG4db3872aabc3: Only build secure/libexec/ssh-sk-helper if MK_USB == no (authored by ngie). · Explain Why
This revision was automatically updated to reflect the committed changes.
ngie added a commit: rG4db3872aabc3: Only build secure/libexec/ssh-sk-helper if MK_USB == no.

Revision Contents
Changeset List

PathSize
secure/
libexec/
4 lines
ssh-sk-helper/
5 lines
tools/
build/
mk/
2 lines

Diff 182476

View Options

secure/libexec/Makefile

Loading...
View Options

secure/libexec/ssh-sk-helper/Makefile

Loading...
View Options

tools/build/mk/OptionalObsoleteFiles.inc

Loading...