Page MenuHomeFreeBSD
Differential D58246

Only build secure/libexec/ssh-sk-helper if MK_USB == no
ClosedPublic
Actions

Authored by ngie on Wed, Jul 15, 12:39 AM.
Tags
None
Referenced Files
F163465983: D58246.id182015.diff
Thu, Jul 23, 10:26 AM
Unknown Object (File)
Wed, Jul 22, 8:39 AM
Unknown Object (File)
Wed, Jul 22, 3:08 AM
Unknown Object (File)
Tue, Jul 21, 12:31 AM
Unknown Object (File)
Tue, Jul 21, 12:30 AM
Unknown Object (File)
Mon, Jul 20, 6:41 PM
Unknown Object (File)
Mon, Jul 20, 1:38 AM
Unknown Object (File)
Sun, Jul 19, 4:00 PM
View All 13 Files
Subscribers
des
imp

Details

Reviewers
emaste
Commits
rG4db3872aabc3: Only build secure/libexec/ssh-sk-helper if MK_USB == no
Summary

The ssh-sk-helper utility only functions if/when MK_USB == yes.
Installing it on systems where MK_USB == no doesn't make sense.

Test Plan

This change unbreaks the build with a VM where MK_USB == no is set.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ngie created this revision.Wed, Jul 15, 12:39 AM
Herald added a subscriber: imp. · View Herald TranscriptWed, Jul 15, 12:39 AM
ngie requested review of this revision.Wed, Jul 15, 12:39 AM
Harbormaster completed remote builds in B74819: Diff 182014.Wed, Jul 15, 12:39 AM
ngie updated this revision to Diff 182015.Wed, Jul 15, 12:46 AM
  • Remove redundant SRCS entry added in original diff.
  • Add MK_USB == no entries to OptionalObsoleteFiles.inc .
Harbormaster completed remote builds in B74820: Diff 182015.Wed, Jul 15, 12:46 AM
ngie edited the summary of this revision. (Show Details)Wed, Jul 15, 12:47 AM
ngie edited the test plan for this revision. (Show Details)
ngie added a reviewer: emaste.
ngie added a subscriber: des.
This revision was not accepted when it landed; it landed in state Needs Review.Wed, Jul 22, 7:34 PM
Closed by commit rG4db3872aabc3: Only build secure/libexec/ssh-sk-helper if MK_USB == no (authored by ngie). · Explain Why
This revision was automatically updated to reflect the committed changes.
ngie added a commit: rG4db3872aabc3: Only build secure/libexec/ssh-sk-helper if MK_USB == no.

Revision Contents
Changeset List

PathSize
secure/
libexec/
4 lines
ssh-sk-helper/
5 lines
tools/
build/
mk/
2 lines

Diff 182476

View Options

secure/libexec/Makefile

Loading...
View Options

secure/libexec/ssh-sk-helper/Makefile

Loading...
View Options

tools/build/mk/OptionalObsoleteFiles.inc

Loading...