frame.h: mark struct trapframe to be preserved

[mchoo]

Summary

There are programs that depend on this structure (e.g. kernel debuggers)
that breaks when the ABI changes.

Signed-off-by: Minsoo Choo <[e-mail]>

[kib]

sys/x86/include/frame.h

50

It is enough to have one instance of this in x86/frame.h. Move one comment out of #ifdef, and remove another.

Then, the wording must be completely different, at least for x86, because the layout is defined by hardware, and its changes in somewhat compatible way.

So I think it would be fine to have sentence like 'struct trapframe is known to kernel debuggers.' But not more.

[mchoo]

cleanup x86

[kib]

sys/x86/include/frame.h

41

Remove this blank line.

Then I suggest you to commit the x86 part.

[mchoo]

remove blank line and separate commit for x86

[kib]

sys/x86/include/frame.h

47

No, move this line to the top-level comment, applicable to both i386 and amd64.

[mchoo]

update misplaced comment

[kib]

Please commit the x86 change.

[mchoo]

In D55189#1261892, @kib wrote:

Please commit the x86 change.

I did in 728adff455a3. Or do you mean submit only x86 change and discard others?

[kib]

In D55189#1261893, @minsoochoo0122_proton.me wrote:

In D55189#1261892, @kib wrote:

Please commit the x86 change.

I did in 728adff455a3. Or do you mean submit only x86 change and discard others?

I do not see this revision in the FreeBSD git repo. I mean literally commit the sys/x86/include part, leaving other arches for their maintainers to review.

[mchoo]

In D55189#1261894, @kib wrote:

In D55189#1261893, @minsoochoo0122_proton.me wrote:

In D55189#1261892, @kib wrote:

Please commit the x86 change.

I did in 728adff455a3. Or do you mean submit only x86 change and discard others?

I do not see this revision in the FreeBSD git repo. I mean literally commit the sys/x86/include part, leaving other arches for their maintainers to review.

For 728adff455a3, I meant under commits tab in this revision. I don't understand what you mean by commit because I don't have commit bit. Sorry if I'm causing miscommunication here, but I'm confused.

[kib]

In D55189#1261895, @minsoochoo0122_proton.me wrote:

In D55189#1261894, @kib wrote:

In D55189#1261893, @minsoochoo0122_proton.me wrote:

In D55189#1261892, @kib wrote:

Please commit the x86 change.

I did in 728adff455a3. Or do you mean submit only x86 change and discard others?

I do not see this revision in the FreeBSD git repo. I mean literally commit the sys/x86/include part, leaving other arches for their maintainers to review.

For 728adff455a3, I meant under commits tab in this revision. I don't understand what you mean by commit because I don't have commit bit. Sorry if I'm causing miscommunication here, but I'm confused.

Ok, send me the git-format patch for the x86 part, with the right author, commit message, and all the metadata. I will push it for you.