devel/freebsd-git-arc: Improve discoverability with new port name
ClosedPublic
Actions

Authored by jrm on Thu, Feb 5, 5:22 PM.

Details

Reviewers

adrian
markj
emaste
ziaee

Commits

R11:dc36452454ab: devel/freebsd-git-arc: Improve discoverability with new port name

Summary

Split the old devel/freebsd-git-devtools port into two separate ports,
including this one, to improve discoverability.

Requested by: adrian, ziaee

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jrm requested review of this revision.Thu, Feb 5, 5:22 PM

jrm created this revision.

Harbormaster completed remote builds in B70436: Diff 171253.Thu, Feb 5, 5:22 PM

jrm mentioned this in D55126: freebsd-git-arc-devtools: Was freebsd-git-devtools.Thu, Feb 5, 5:42 PM

ziaee added inline comments.Thu, Feb 5, 5:54 PM

devel/freebsd-git-arc/Makefile
10	This is too long and wraps, how's this?

jrm added inline comments.Thu, Feb 5, 6:07 PM

devel/freebsd-git-arc/Makefile
10	Where do you see it wrapping? We're supposed to be fine with up to 70 characters, and this is only 62. https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-comment

ziaee added inline comments.Thu, Feb 5, 6:26 PM

devel/freebsd-git-arc/Makefile
10	I see it wrapping in the output of `pkg sea git` on 80x25 vt on my 14" laptop.
devel/git-arc/pkg-descr
2 ↗	(On Diff #171253)

jrm added inline comments.Thu, Feb 5, 7:18 PM

devel/freebsd-git-arc/Makefile
10	We can trim it down, but this is surprising. Using the default fonts on the 12.5" screen of an X220, it's not even close to wrapping.

jrm attached a referenced file: F144163378: image.png. (Show Details)Thu, Feb 5, 7:18 PM

Update COMMENT and pkg-descr based on discussion with @ziaee

Harbormaster completed remote builds in B70445: Diff 171280.Thu, Feb 5, 7:43 PM

jrm added inline comments.Thu, Feb 5, 7:45 PM

devel/freebsd-git-arc/Makefile
10	Does the current `COMMENT` fit?

devel/git-arc would be appropriate if this were a generic Git plugin for Arcanist interoperability, but it isn't — it's hardcoded to only work with FreeBSD's Phabricator instance. It should at the very least be devel/freebsd-git-arc. Or you could just leave well enough alone.

devel/freebsd-git-arc makes sense and sounds good to me. Then it will still come up if people search freebsd, which should be an expected usecase for freebsd specific tooling i think.

devel/freebsd-git-arc/Makefile
10	Yes, with one character to spare

jrm retitled this revision from devel/git-arc: Improve discoverability with new port name to devel/freebsd-git-arc: Improve discoverability with new port name.Thu, Feb 5, 8:07 PM

Use devel/freebsd-git-arc for new port name

Harbormaster completed remote builds in B70446: Diff 171281.Thu, Feb 5, 8:08 PM

jrm added child revisions: D55131: committers-guide: Update reference to devel/freebsd-git-tools, D55130: devel/mfc-candidates: Improve discoverability with new port name, D55128: development.7: Update references to devel/freebsd-git-tools, D55127: git-arc.1: Update reference to port with new port name.Thu, Feb 5, 8:17 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sat, Feb 7, 3:39 AM

Closed by commit R11:dc36452454ab: devel/freebsd-git-arc: Improve discoverability with new port name (authored by jrm). · Explain Why

This revision was automatically updated to reflect the committed changes.

jrm added a commit: R11:dc36452454ab: devel/freebsd-git-arc: Improve discoverability with new port name.