Page MenuHomeFreeBSD

stand/efi: Allow RELAXED or STRICT boot policies
ClosedPublic

Authored by imp on Wed, Feb 4, 5:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 19, 6:09 AM
Unknown Object (File)
Fri, Feb 13, 8:18 AM
Unknown Object (File)
Thu, Feb 12, 3:44 AM
Unknown Object (File)
Thu, Feb 12, 2:59 AM
Unknown Object (File)
Thu, Feb 12, 2:55 AM
Unknown Object (File)
Thu, Feb 12, 2:28 AM
Unknown Object (File)
Thu, Feb 12, 2:16 AM
Unknown Object (File)
Wed, Feb 11, 4:04 PM
Subscribers

Details

Summary

The RELAXED boot policy will automatically search for any root
filesystem (currently zfs only) on any device. STRICT policy only
searches on the boot device.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Wed, Feb 4, 5:46 PM

assume the boot dev are first on list.

lookup table for values.

Oh, I don't need the on_bootdev stuff. Simplify.

Oh, don't make silly changes, so we're down to main.c only now.

stand/efi/loader/main.c
151–154

This will make two declarations better coupled together.

614–616

Didn't you you want to skip entries that don't match the condition instead of breaking the cycle? What if next entry is actually the one we want?

stand/efi/loader/main.c
614–616

Now that I've seen your change to D55094, I see that there is no difference between breaking the cycle or skipping entries. So whatever works. But in case if you prefer breaking the cycle, I will suggest to put a comment explaining why we sure that no good entry is there in the list, referencing the other file.

stand/efi/loader/main.c
614–616

I think that continue w/o head-insert is better and simpler, so I'll do that. Thanks for the suggestion.

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Feb 27, 1:02 AM
This revision was automatically updated to reflect the committed changes.