Page MenuHomeFreeBSD
Differential D55051

arm64: Add MOPS implementations of memset(), memcpy() and memmove()
ClosedPublic
Actions

Authored by sarah.walker2_arm.com on Mon, Feb 2, 10:02 AM.
Tags
None
Referenced Files
F146153021: D55051.diff
Sat, Feb 28, 6:52 AM
Unknown Object (File)
Tue, Feb 24, 9:28 AM
Unknown Object (File)
Thu, Feb 19, 3:44 AM
Unknown Object (File)
Thu, Feb 19, 3:44 AM
Unknown Object (File)
Wed, Feb 18, 4:45 PM
Unknown Object (File)
Wed, Feb 18, 4:45 PM
Unknown Object (File)
Wed, Feb 18, 4:45 PM
Unknown Object (File)
Tue, Feb 10, 2:06 PM
View All 14 Files
Subscribers
emaste
imp
olce

Details

Reviewers
andrew
manu
Commits
rG2ccbf06c0285: arm64: Add MOPS implementations of memset(), memcpy() and memmove()
Summary

Enable the use of MOPS implementations of memset, memcpy and memmove within
the kernel. Fix pre-ifunc resolution uses of these functions.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sarah.walker2_arm.com created this revision.Mon, Feb 2, 10:02 AM
Herald added a reviewer: andrew. · View Herald TranscriptMon, Feb 2, 10:02 AM
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added subscribers: emaste, imp. · View Herald Transcript
sarah.walker2_arm.com requested review of this revision.Mon, Feb 2, 10:02 AM
Harbormaster completed remote builds in B70341: Diff 170975.Mon, Feb 2, 10:02 AM
sarah.walker2_arm.com mentioned this in D54943: arm64: Enable MOPS usage in the kernel.Mon, Feb 2, 10:02 AM
andrew added a comment.Tue, Feb 3, 11:22 AM

I think we will need to also update the calls to memset/bzero in pmap_bootstrap_*. These functions are used by the kernel sanitizers to build the early shadow region.

andrew mentioned this in D55075: kern linker: Mark link_elf_ireloc as no-KASAN.Tue, Feb 3, 12:29 PM
sarah.walker2_arm.com updated this revision to Diff 171508.Mon, Feb 9, 11:52 AM

Remove mops_supported.

Harbormaster completed remote builds in B70542: Diff 171508.Mon, Feb 9, 11:52 AM
andrew added a comment.Mon, Feb 9, 5:39 PM

It looks like this is missing the pmap changes for the sanitizer kernels.

sarah.walker2_arm.com updated this revision to Diff 171633.Tue, Feb 10, 9:58 AM

KASAN fixes.

Herald added a subscriber: olce. · View Herald TranscriptTue, Feb 10, 9:58 AM
Harbormaster completed remote builds in B70577: Diff 171633.Tue, Feb 10, 9:59 AM
andrew accepted this revision.Tue, Feb 10, 3:26 PM
This revision is now accepted and ready to land.Tue, Feb 10, 3:26 PM
Closed by commit rG2ccbf06c0285: arm64: Add MOPS implementations of memset(), memcpy() and memmove() (authored by sarah.walker2_arm.com, committed by andrew). · Explain WhyTue, Feb 10, 3:43 PM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG2ccbf06c0285: arm64: Add MOPS implementations of memset(), memcpy() and memmove().

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
5 lines
38 lines
2 lines
24 lines
12 lines
10 lines
include/
7 lines

Diff 171673

View Options

sys/arm64/arm64/identcpu.c

Loading...
View Options

sys/arm64/arm64/machdep.c

Loading...
View Options

sys/arm64/arm64/machdep_boot.c

Loading...
View Options

sys/arm64/arm64/memcpy.S

Loading...
View Options

sys/arm64/arm64/memset.S

Loading...
View Options

sys/arm64/arm64/pmap.c

Loading...
View Options

sys/arm64/include/cpu.h

Loading...