Page MenuHomeFreeBSD
Differential D54918

ifconfig: Report errors from failed FIB commands
ClosedPublic
Actions

Authored by markj on Tue, Jan 27, 6:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 31, 8:15 AM
Unknown Object (File)
Sat, Jan 31, 6:30 AM
Unknown Object (File)
Fri, Jan 30, 11:11 PM
Unknown Object (File)
Thu, Jan 29, 8:07 AM
Unknown Object (File)
Wed, Jan 28, 5:59 PM
Unknown Object (File)
Wed, Jan 28, 7:07 AM
Unknown Object (File)
Wed, Jan 28, 1:56 AM
Unknown Object (File)
Wed, Jan 28, 1:21 AM
Subscribers
imp
melifaro
pouria
zlei

Details

Reviewers
pouria
zlei
melifaro
Group Reviewers
network
Commits
rG2ea85a622bcb: ifconfig: Exit with a non-zero status when SIOCSIFFIB fails
Summary

Previously, setting an interface FIB to some invalid value would result
in a warning being printed, but the ifconfig command would exit with
status 0, but this seems wrong.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Tue, Jan 27, 6:32 PM
Herald added a subscriber: imp. · View Herald TranscriptTue, Jan 27, 6:32 PM
markj requested review of this revision.Tue, Jan 27, 6:32 PM
Harbormaster completed remote builds in B70171: Diff 170547.Tue, Jan 27, 6:32 PM
pouria accepted this revision as: pouria.Tue, Jan 27, 9:20 PM
pouria added a subscriber: pouria.

LGTM

This revision is now accepted and ready to land.Tue, Jan 27, 9:20 PM
zlei accepted this revision as: zlei.Wed, Jan 28, 3:20 AM
zlei added a subscriber: zlei.

Looks good to me.

zlei added a subscriber: melifaro.Wed, Jan 28, 3:28 AM
zlei added inline comments.
sbin/ifconfig/iffib.c
97

CC the author @melifaro to see if the warn() is intentional .

melifaro accepted this revision.Wed, Jan 28, 11:27 AM
Closed by commit rG2ea85a622bcb: ifconfig: Exit with a non-zero status when SIOCSIFFIB fails (authored by markj). · Explain WhyWed, Jan 28, 4:14 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG2ea85a622bcb: ifconfig: Exit with a non-zero status when SIOCSIFFIB fails.

Revision Contents
Changeset List

PathSize
sbin/
ifconfig/
16 lines
tests/
3 lines
32 lines

Diff 170647

View Options

sbin/ifconfig/iffib.c

Loading...
View Options

sbin/ifconfig/tests/Makefile

Loading...
View Options

sbin/ifconfig/tests/ifconfig.sh

Loading...