Differential D54397

netlink: Consistently use unsigned types for message and buffer lengths
Needs ReviewPublic
Actions

Authored by jhb on Mon, Dec 29, 4:26 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Dec 31, 2:11 PM

	Unknown Object (File)
	Wed, Dec 31, 1:33 PM

	Unknown Object (File)
	Wed, Dec 31, 12:45 PM

	Unknown Object (File)
	Wed, Dec 31, 12:44 PM

	Unknown Object (File)
	Wed, Dec 31, 12:08 PM

Subscribers

Details

Reviewers

kp
igoro
melifaro

Summary

While here, fix a few length checks that did not handle overflow.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 69528
Build 66411: arc lint + arc unit

Event Timeline

jhb created this revision.Mon, Dec 29, 4:26 PM

Herald added a reviewer: melifaro. · View Herald TranscriptMon, Dec 29, 4:26 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript

jhb requested review of this revision.Mon, Dec 29, 4:26 PM

Harbormaster completed remote builds in B69501: Diff 168705.Mon, Dec 29, 4:26 PM

Pass tinderbox

Harbormaster completed remote builds in B69528: Diff 168778.Tue, Dec 30, 4:29 PM

jhb mentioned this in D54162: netlink: Optimize growing the snl_writer message buffer.Tue, Dec 30, 4:32 PM

jhb added a child revision: D54162: netlink: Optimize growing the snl_writer message buffer.Tue, Dec 30, 4:32 PM

melifaro added inline comments.Thu, Jan 1, 3:48 PM

sys/netlink/netlink.h
260	That's compat with Linux definition, let's keep as is - https://github.com/torvalds/linux/blob/b69053dd3ffbc0d2dedbbc86182cdef6f641fe1b/tools/include/uapi/linux/netlink.h#L232
sys/netlink/netlink_snl.h
56	Looks like it's already defined in netlink.h, so can prob be removed

Revision Contents
Changeset List

Path

Size

sys/

netlink/

2 lines

72 lines

usr.bin/

genl/

2 lines

Diff 168778

sys/netlink/netlink.h

Loading...

sys/netlink/netlink_snl.h

Loading...

usr.bin/genl/parser_rpc.c

Loading...