Paths

Table of Contentst

Differential D54043

headers: Remove redundant checks for __BSD_VISIBLE
Needs ReviewPublic
Actions

Authored by imp on Wed, Dec 3, 4:46 AM.

Tags

None

Referenced Files

	F140860613: D54043.id54425.diff
	Sun, Dec 28, 11:15 PM

	Unknown Object (File)
	Sat, Dec 27, 10:39 AM

	Unknown Object (File)
	Sat, Dec 20, 2:22 AM

	Unknown Object (File)
	Fri, Dec 19, 10:01 AM

	Unknown Object (File)
	Thu, Dec 18, 7:49 AM

	Unknown Object (File)
	Mon, Dec 15, 6:13 AM

	Unknown Object (File)
	Thu, Dec 4, 8:16 PM

	Unknown Object (File)
	Wed, Dec 3, 11:38 AM

View All 10 Files

Subscribers

Details

Reviewers

andrew
manu
jrtc27
fuz

Summary

We assume that __BSD_VISIBLE is always defined when different subsetting
functions are in place. No need to test for it in these cases. The only
time you should test for it is when POSIX, ISOC or XPG has removed
functionality in newer releases and we omit defining those functions,
defines, etc in that case.

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 69007
Build 65890: arc lint + arc unit

Event Timeline

imp created this revision.Wed, Dec 3, 4:46 AM

Herald added a reviewer: andrew. · View Herald TranscriptWed, Dec 3, 4:46 AM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added subscribers: riscv, jhibbits, emaste. · View Herald Transcript

imp requested review of this revision.Wed, Dec 3, 4:46 AM

Harbormaster completed remote builds in B69007: Diff 167462.Wed, Dec 3, 4:46 AM

imp added reviewers: jrtc27, fuz.Wed, Dec 3, 4:47 AM

fuz added inline comments.Wed, Dec 3, 12:56 PM

sys/arm64/include/setjmp.h
68	Shouldn't `__XSI_VISIBLE` imply `__POSIX_VISIBLE`?

Revision Contents
Changeset List

Path

Size

include/

2 lines

2 lines

4 lines

lib/

msun/

src/

16 lines

sys/

arm/

include/

2 lines

arm64/

include/

2 lines

powerpc/

include/

2 lines

riscv/

include/

2 lines

sys/

9 lines

2 lines

x86/

include/

2 lines

Diff 167462

include/stdckdint.h

Loading...

include/string.h

Loading...

include/strings.h

Loading...

lib/msun/src/math.h

Loading...

sys/arm/include/setjmp.h

Loading...

sys/arm64/include/setjmp.h

Loading...

sys/powerpc/include/setjmp.h

Loading...

sys/riscv/include/setjmp.h

Loading...

sys/sys/_endian.h

Loading...

sys/sys/signal.h

Loading...

sys/x86/include/setjmp.h

Loading...