bsdinstall: Add loader.efi to all ESPs we create
ClosedPublic
Actions

Authored by imp on Mon, Sep 29, 9:37 AM.

Details

Reviewers

cperciva
ivy

Commits

rGd8e73f45fc5f: bsdinstall: Add loader.efi to all ESPs we create
rG4b734c477446: bsdinstall: Add loader.efi to all ESPs we create
rG494de51bc007: bsdinstall: Add loader.efi to all ESPs we create

Summary

Add the proper loader.efi to each of the ESPs we create. zfsboot creates
a list of extra ESPs to populate. For both UFS and ZFS, the first ESP is
mounted and we copy the files over (using the same heuristic for the
platform default file). zfsboot-noted ESPs will get copies as well. We
don't have to do anything for UFS since we don't support installing into
a gmirror, but if we ever do, we can use this mechanism.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Mon, Sep 29, 9:37 AM

Herald added a subscriber: jrtc27. · View Herald TranscriptMon, Sep 29, 9:37 AM

imp requested review of this revision.Mon, Sep 29, 9:37 AM

Harbormaster completed remote builds in B67387: Diff 163011.Mon, Sep 29, 9:37 AM

imp edited the test plan for this revision. (Show Details)Mon, Sep 29, 9:38 AM

imp added reviewers: cperciva, ivy.

imp added inline comments.

usr.sbin/bsdinstall/scripts/zfsboot
1024	This was stray, it seems, from earlier revs.

Minor nits.

usr.sbin/bsdinstall/scripts/auto
182	Isn't this usually spelled `: > ${TMPDIR:-"/tmp"}/bsdinstall-esps` ? (In particular, it avoids needing to open /dev/null. I can't imagine a scenario where /dev/ isn't mounted here, but why rely on it?)
usr.sbin/bsdinstall/scripts/bootconfig
149	`appends` ?
150	`don't support installing` ?
153	This could just be `mktemp -d -t bsdinstall-esp` since the use of TMPDIR (if set) or `/tmp` (otherwise) is implied.