Page MenuHomeFreeBSD

Convert rman to use rman_res_t instead of u_long
ClosedPublic

Authored by jhibbits on Jan 26 2016, 3:58 AM.

Details

Summary

Migrate to using the semi-opaque type rman_res_t to specify rman resources. For now, this is still compatible with u_long.

This is step one in migrating rman to use uintmax_t for resources instead of
u_long.

Going forward, this could feasibly be used to specify architecture-specific definitions of resource ranges, rather than baking a specific integer type into the API.

This change has been broken out to facilitate MFC'ing drivers back to 10 without
breaking ABI.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jhibbits retitled this revision from to Convert rman to use rman_res_t instead of u_long.
jhibbits updated this object.
jhibbits edited the test plan for this revision. (Show Details)
jhibbits added a reviewer: jhb.

Fine with me once you fix the sys/dev/ed thing.

I would suggest adding some more to the commit message to describe what this change is doing beyond being step one. That is I would specifically mention that you are adding the 'rman_res_t' type to represent the range type for rman but leaving it as u_long for now.

sys/dev/ed/if_ed_3c503.c
80 ↗(On Diff #12703)

This line should be restored.

sys/sys/bus.h
32 ↗(On Diff #12703)

Do you need this #include for this change?

jhibbits added inline comments.
sys/dev/ed/if_ed_3c503.c
80 ↗(On Diff #12703)

Hmm, this must've been a merge problem. This delete wasn't in my original patch and this diff is purely a reduction of the other patch.

jhibbits marked an inline comment as done.
jhibbits edited edge metadata.

Address jhb's comments.

jhibbits edited edge metadata.
jhb edited edge metadata.
This revision is now accepted and ready to land.Jan 27 2016, 2:08 AM
This revision was automatically updated to reflect the committed changes.