Add FDT bus capabilities to ThunderX PCI driver

[zbb]

Summary

New ThunderX firmware incorporates modified DTB that presents
different device hierarchy. In the new device tree, MDIO
devices are below two additional buses that oddly hang on
PCI bridge.

[wma]

Looks good to me, but someone else should approve.

sys/arm64/cavium/thunder_pcie_common.c

48 ↗

(On Diff #12688)

Change to: 'Thunder PCie driver memory' or anything specifying which memory it's all about.

[andrew]

sys/arm64/cavium/thunder_pcie.c

408 ↗

(On Diff #12721)

Why do you need this ifndef?

sys/arm64/cavium/thunder_pcie_fdt.c

270–271 ↗

(On Diff #12721)

Be warned that you may need to change this because of D5075

279 ↗

(On Diff #12721)

When does this return < 0?

[zbb]

sys/arm64/cavium/thunder_pcie.c

408 ↗

(On Diff #12721)

Hmm. Won't bus_alloc_resource and bus_release_resource here interfere with the same in thunder_pcie_fdt.c?

sys/arm64/cavium/thunder_pcie_fdt.c

270–271 ↗

(On Diff #12721)

OK I will keep that in mind, thanks!

279 ↗

(On Diff #12721)

You are right. This will be either == 0 or > 0.
I must have mistaken it with OF_<smthing> class of functions. I will fix that in the next iteration.

[andrew]

sys/arm64/cavium/thunder_pcie.c

408 ↗

(On Diff #12786)

If you've overridden a function it should be used. We rely on this, e.g. to override the device_attach function.

sys/arm64/cavium/thunder_pcie_fdt.c

270–271 ↗

(On Diff #12786)

It has now been committed, you will need to update the type.

[zbb]

sys/arm64/cavium/thunder_pcie_fdt.c

270–271 ↗

(On Diff #12786)

It is done in the current diff. Did you check?

[zbb]

sys/arm64/cavium/thunder_pcie.c

408 ↗

(On Diff #12786)

OK

[andrew]

sys/arm64/cavium/thunder_pcie_fdt.c

270–271 ↗

(On Diff #12786)

Which diff? I don't see it here.

[zbb]

sys/arm64/cavium/thunder_pcie_fdt.c

270–271 ↗

(On Diff #12786)

Agr sorry my bad. Didn't upload this one.
I will upload with the removed FDT above in a minute.