Paths

Table of Contentst

Differential D5070

Support new MDIO hierarchy in ThunderX DTB
ClosedPublic
Actions

Authored by zbb on Jan 25 2016, 3:47 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 19, 1:54 PM

	Unknown Object (File)
	Sat, Nov 16, 8:32 AM

	Unknown Object (File)
	Thu, Nov 14, 3:02 AM

	Unknown Object (File)
	Thu, Oct 31, 8:28 PM

	Unknown Object (File)
	Wed, Oct 30, 9:50 PM

	Unknown Object (File)
	Oct 10 2024, 11:38 AM

	Unknown Object (File)
	Oct 10 2024, 11:38 AM

	Unknown Object (File)
	Oct 10 2024, 11:38 AM

View All 74 Files

Subscribers

Details

Reviewers

wma
andrew
imp
• ian

Commits

rS294994: Support new MDIO hierarchy in ThunderX DTB

Summary

Some firmware revisions provide different DTB tree that include
odd MDIO placement in the tree.
This commit adds support for 2 new buses:

MRML bridge (PCIB subordinate)
MDIO nexus (MRML subordinate)

This allows for the correct MDIO attachment with both - new and old
firmware.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zbb updated this revision to Diff 12689.Jan 25 2016, 3:47 PM

zbb retitled this revision from to Support new MDIO hierarchy in ThunderX DTB.

zbb updated this object.

zbb edited the test plan for this revision. (Show Details)

zbb added reviewers: andrew, imp, • ian, wma.

zbb set the repository for this revision to rS FreeBSD src repository - subversion.

zbb added a subscriber: arm64.

Herald added a subscriber: emaste. · View Herald TranscriptJan 25 2016, 3:47 PM

zbb added a parent revision: D5069: Add FDT bus capabilities to ThunderX PCI driver.Jan 25 2016, 3:49 PM

zbb added inline comments.Jan 28 2016, 12:07 PM

sys/conf/files.arm64
74 ↗	(On Diff #12689)	I will add `fdt` dependency here in the final commit.

andrew added inline comments.Jan 28 2016, 12:21 PM

sys/dev/vnic/mrml_bridge.c
139 ↗	(On Diff #12689)	Change to use `rman_res_t`
162 ↗	(On Diff #12689)	`device_get_softc` returns a `void *`, there is no need to cast here.
250 ↗	(On Diff #12689)	Cast?
sys/dev/vnic/thunder_mdio_fdt.c
111 ↗	(On Diff #12689)	Why not just use this directly?

zbb added inline comments.Jan 28 2016, 12:33 PM

sys/dev/vnic/mrml_bridge.c
139 ↗	(On Diff #12689)	OK
162 ↗	(On Diff #12689)	It was done on purpose because the `softc` of this driver contains `simplebus_softc`. I wanted to make that clear that we extract the `simplebus_softc` only.
250 ↗	(On Diff #12689)	Same as above.
sys/dev/vnic/thunder_mdio_fdt.c
111 ↗	(On Diff #12689)	Yeah, this may simplify everything here.

andrew added inline comments.Jan 28 2016, 12:38 PM

sys/dev/vnic/mrml_bridge.c
162 ↗	(On Diff #12689)	Why not have this driver use `simplebus_softc` directly then?

zbb added inline comments.Jan 28 2016, 12:39 PM

sys/dev/vnic/mrml_bridge.c
162 ↗	(On Diff #12689)	As I wrote in a comment below - I agree.

zbb updated this revision to Diff 12790.Jan 28 2016, 1:11 PM

zbb marked 10 inline comments as done.Jan 28 2016, 1:13 PM

zbb marked an inline comment as done.

Closed by commit rS294994: Support new MDIO hierarchy in ThunderX DTB (authored by zbb). · Explain WhyJan 28 2016, 3:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

conf/

1 line

dev/

vnic/

280 lines

thunder_mdio_fdt.c

204 lines

thunder_mdio_var.h

1 line

Diff 12800

head/sys/conf/files.arm64

Loading...

head/sys/dev/vnic/mrml_bridge.c

Loading...

head/sys/dev/vnic/thunder_mdio_fdt.c

Loading...

head/sys/dev/vnic/thunder_mdio_var.h

Loading...