Page MenuHomeFreeBSD
Differential D50011

mail: Don't trap signals we shouldn't.
ClosedPublic
Actions

Authored by des on Apr 24 2025, 10:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 21, 11:13 AM
Unknown Object (File)
Tue, May 20, 9:57 PM
Unknown Object (File)
Fri, May 16, 11:31 AM
Unknown Object (File)
Sun, May 11, 2:22 PM
Unknown Object (File)
Wed, May 7, 7:07 AM
Unknown Object (File)
Tue, May 6, 1:27 PM
Unknown Object (File)
May 5 2025, 9:54 AM
Unknown Object (File)
Apr 28 2025, 11:33 PM
View All 13 Files
Subscribers
imp
kevans
ziaee

Details

Reviewers
kevans
Group Reviewers
Klara
Commits
rG12666df00a74: mail: Don't trap signals we shouldn't.
rG59597032c948: mail: Don't trap signals we shouldn't.
Summary

When in interactive mode, trap SIGINT, SIGHUP, and tty-related signals.
Otherwise, leave signals untouched as required by POSIX.

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Apr 24 2025, 10:03 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 24 2025, 10:03 PM
des requested review of this revision.Apr 24 2025, 10:03 PM
Harbormaster completed remote builds in B63712: Diff 154242.Apr 24 2025, 10:03 PM
kevans added a subscriber: kevans.Apr 24 2025, 10:49 PM
kevans added inline comments.
usr.bin/mail/collect.c
82–85

Looking at the standard, it's not clear to me that this is actually correct. ASYNCHRONOUS EVENTS explciitly spells out ignore handling only in the interactive case as something evaluated when a SIGINT rolls in, and otherwise has:

When mailx is in Send Mode and standard input is not a terminal, it shall take the standard action for all signals.

I think we should continue to leave SIGINT alone in the non-interactive case.

ziaee added a subscriber: ziaee.Apr 25 2025, 1:15 AM
des edited the summary of this revision. (Show Details)Apr 25 2025, 12:33 PM
des updated this revision to Diff 154272.Apr 25 2025, 12:34 PM

review feedback

Harbormaster completed remote builds in B63722: Diff 154272.Apr 25 2025, 12:34 PM
kevans accepted this revision.Apr 25 2025, 1:56 PM
This revision is now accepted and ready to land.Apr 25 2025, 1:56 PM
Closed by commit rG59597032c948: mail: Don't trap signals we shouldn't. (authored by des). · Explain WhyApr 27 2025, 6:30 AM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG59597032c948: mail: Don't trap signals we shouldn't..
des added a commit: rG12666df00a74: mail: Don't trap signals we shouldn't..Wed, May 21, 5:48 PM

Revision Contents
Changeset List

PathSize
etc/
mtree/
2 lines
usr.bin/
mail/
5 lines
34 lines
tests/
4 lines
149 lines

Diff 154342

View Options

etc/mtree/BSD.tests.dist

Loading...
View Options

usr.bin/mail/Makefile

Loading...
View Options

usr.bin/mail/collect.c

Loading...
View Options

usr.bin/mail/tests/Makefile

Loading...
View Options

usr.bin/mail/tests/mail_sigint_test.c

Loading...