kassert: Turn 'poisoned_buf' into a 'void *'
ClosedPublic
Actions

Authored by olce on Apr 23 2025, 10:04 AM.

Details

Reviewers

markj
emaste

Commits

rGb0d4c946572d: kassert: Turn 'poisoned_buf' into a 'void *'

Summary

This is a step to make <sys/kassert.h> usable without the need to
explicitly include other headers.

'poisoned_buf' is only used for its value and never subject to pointer
arithmetics. Keeping 'caddr_t' would require <sys/kassert.h> to include
<sys/types.h> (at least on INVARIANTS).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

olce created this revision.Apr 23 2025, 10:04 AM

Herald added a subscriber: imp. · View Herald TranscriptApr 23 2025, 10:04 AM

olce requested review of this revision.Apr 23 2025, 10:04 AM

Harbormaster completed remote builds in B63658: Diff 154149.Apr 23 2025, 10:04 AM

olce added a parent revision: D49970: queue: Consistent single space after all #define.Apr 23 2025, 10:19 AM

olce added a child revision: D49972: kassert: Explicitly include <sys/_types>.

markj accepted this revision.Apr 23 2025, 9:01 PM

This revision is now accepted and ready to land.Apr 23 2025, 9:01 PM

Closed by commit rGb0d4c946572d: kassert: Turn 'poisoned_buf' into a 'void *' (authored by olce). · Explain WhyApr 28 2025, 12:24 PM

This revision was automatically updated to reflect the committed changes.

olce added a commit: rGb0d4c946572d: kassert: Turn 'poisoned_buf' into a 'void *'.

Revision Contents
Changeset List

Path

Size

sys/

kern/

vfs_bio.c

2 lines

sys/

kassert.h

4 lines

Diff 154398

View Options

sys/kern/vfs_bio.c