Details

Reviewers

emaste
pstef
kib

Commits

rG220800ca96ba: ps(1): Constify the format strings for canned displays
rGfd6b81712eb9: ps(1): Constify the format strings for canned displays

Summary

Now that removal of non-explicitly-requested duplicate columns work with
a O(n) algorithm, remove the optimization of crushing the canned
displays' formats after first use and constify their format strings.

No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

olce created this revision.Apr 1 2025, 1:38 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 1 2025, 1:38 PM

olce requested review of this revision.Apr 1 2025, 1:38 PM

Harbormaster completed remote builds in B63256: Diff 152974.Apr 1 2025, 1:38 PM

olce added a parent revision: D49613: ps.1: Note that automatic removal of duplicate columns has been fixed.Apr 1 2025, 1:39 PM

olce added a child revision: D49615: ps(1): Make '-O' more versatile and predictable.

olce added reviewers: pstef, kib.Apr 1 2025, 4:25 PM

olce added a child revision: D49608: queue: Add STAILQ_SPLIT_AFTER() and STAILQ_ASSERT_NONEMPTY().Apr 28 2025, 10:04 AM

olce removed a child revision: D49615: ps(1): Make '-O' more versatile and predictable.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 28 2025, 12:24 PM

Closed by commit rGfd6b81712eb9: ps(1): Constify the format strings for canned displays (authored by olce). · Explain Why

This revision was automatically updated to reflect the committed changes.

olce added a commit: rGfd6b81712eb9: ps(1): Constify the format strings for canned displays.

olce added a commit: rG220800ca96ba: ps(1): Constify the format strings for canned displays.May 1 2025, 7:54 PM

ps(1): Constify the format strings for canned displays
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 154395

bin/ps/ps.c

ps(1): Constify the format strings for canned displaysClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 154395

bin/ps/ps.c

ps(1): Constify the format strings for canned displays
ClosedPublic
Actions

Revision Contents
Changeset List