Page MenuHomeFreeBSD

kassert: Explicitly include <sys/_types>
AcceptedPublic

Authored by olce on Wed, Apr 23, 10:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 24, 8:46 PM
Unknown Object (File)
Thu, Apr 24, 6:58 AM
Unknown Object (File)
Thu, Apr 24, 1:59 AM
Unknown Object (File)
Thu, Apr 24, 1:09 AM
Unknown Object (File)
Wed, Apr 23, 8:42 PM
Unknown Object (File)
Wed, Apr 23, 5:11 PM
Unknown Object (File)
Wed, Apr 23, 4:43 PM
Unknown Object (File)
Wed, Apr 23, 4:09 PM
Subscribers

Details

Reviewers
markj
emaste
imp
Summary

Including it is needed to have '__va_list' defined.

This is a step to make <sys/kassert.h> usable without the need to
explicitly include other headers.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 63659
Build 60543: arc lint + arc unit

Event Timeline

olce requested review of this revision.Wed, Apr 23, 10:04 AM

title should likely say _types.h though.
And do you still need cdefs.h, since _types.h already does? style(9) says types.h, but maybe we need to update that too?

This revision is now accepted and ready to land.Wed, Apr 23, 8:49 PM
In D49972#1140034, @imp wrote:

title should likely say _types.h though.
And do you still need cdefs.h, since _types.h already does? style(9) says types.h, but maybe we need to update that too?

I could have sworn that style.9 says that one can assume that param.h and (_)types.h include cdefs.h, but I can't find any mention of that.

IMO it's okay to drop the cdefs include, but it doesn't matter much here.